Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auto Suggest] PPL autocomplete fixes #8087

Merged
merged 11 commits into from
Sep 12, 2024
Merged

[Auto Suggest] PPL autocomplete fixes #8087

merged 11 commits into from
Sep 12, 2024

Conversation

paulstn
Copy link
Contributor

@paulstn paulstn commented Sep 9, 2024

Description

Fixes various issues for ppl autocomplete.

Note: Can ignore changes in the .generated folder

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: PPL Autocomplete functions, fields, & table suggestion

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@paulstn paulstn requested a review from huyaboo as a code owner September 9, 2024 16:38
@codecov Codecov
Copy link

codecov bot commented Sep 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 15.78947% with 16 lines in your changes missing coverage. Please review.

Project coverage is 64.03%. Comparing base (ee5d482) to head (66896fa).
Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
...ata/public/antlr/opensearch_ppl/code_completion.ts 0.00% 14 Missing ⚠️
...ntlr/opensearch_ppl/opensearch_ppl_autocomplete.ts 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8087      +/-   ##
==========================================
+ Coverage   60.58%   64.03%   +3.44%     
==========================================
  Files        3738     3740       +2     
  Lines       88670    88570     -100     
  Branches    13782    13786       +4     
==========================================
+ Hits        53725    56712    +2987     
+ Misses      31661    31262     -399     
+ Partials     3284      596    -2688
Flag Coverage Δ
Linux_1 30.03% <10.52%> (+1.27%) ⬆️
Linux_2 58.79% <ø> (+2.52%) ⬆️
Linux_3 40.39% <15.78%> (+2.87%) ⬆️
Linux_4 31.47% <10.52%> (+1.86%) ⬆️
Windows_1 30.05% <10.52%> (+1.27%) ⬆️
Windows_2 58.74% <ø> (+2.52%) ⬆️
Windows_3 40.39% <15.78%> (+2.87%) ⬆️
Windows_4 31.47% <10.52%> (+1.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulstn
update user hints
9f7cac1 
Signed-off-by: Paul Sebastian <[email protected]>
@paulstn
update types
66896fa 
Signed-off-by: Paul Sebastian <[email protected]>
joshuali925
joshuali925 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just questions

src/plugins/data/public/antlr/opensearch_ppl/grammar/OpenSearchPPLParser.g4 Show resolved Hide resolved
src/plugins/data/public/antlr/opensearch_ppl/opensearch_ppl_autocomplete.ts Show resolved Hide resolved
@kavilla kavilla merged commit 8118024 into opensearch-project:main Sep 12, 2024
66 of 67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 12, 2024
@github-actions @opensearch-changeset-bot
[Auto Suggest] PPL autocomplete fixes (#8087)
8395ecc 
* add stats agg functions and insert snippet rules

Signed-off-by: Paul Sebastian <[email protected]>

* allow table suggestions with table name

Signed-off-by: Paul Sebastian <[email protected]>

* stop suggestion search from filter

Signed-off-by: Paul Sebastian <[email protected]>

* keep user hint height and pos constant

Signed-off-by: Paul Sebastian <[email protected]>

* fix issue where identifiers would suggest twice, after WS

Signed-off-by: Paul Sebastian <[email protected]>

* add some priority based tokens to appear at the top

Signed-off-by: Paul Sebastian <[email protected]>

* reenable plus and minus for sort command

Signed-off-by: Paul Sebastian <[email protected]>

* Changeset file for PR #8087 created/updated

* update user hints

Signed-off-by: Paul Sebastian <[email protected]>

* update types

Signed-off-by: Paul Sebastian <[email protected]>

---------

Signed-off-by: Paul Sebastian <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 8118024)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 12, 2024
Merged
kavilla pushed a commit that referenced this pull request Sep 13, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[Auto Suggest] PPL autocomplete fixes (#8087) (#8172)
421b0eb 
* add stats agg functions and insert snippet rules



* allow table suggestions with table name



* stop suggestion search from filter



* keep user hint height and pos constant



* fix issue where identifiers would suggest twice, after WS



* add some priority based tokens to appear at the top



* reenable plus and minus for sort command



* Changeset file for PR #8087 created/updated

* update user hints



* update types



---------



(cherry picked from commit 8118024)

Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@ashwin-pc ashwin-pc added 2.17.1 and removed v2.18.0 labels Sep 17, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 20, 2024
@github-actions @opensearch-changeset-bot
[Auto Suggest] PPL autocomplete fixes (#8087)
c68e245 
* add stats agg functions and insert snippet rules

Signed-off-by: Paul Sebastian <[email protected]>

* allow table suggestions with table name

Signed-off-by: Paul Sebastian <[email protected]>

* stop suggestion search from filter

Signed-off-by: Paul Sebastian <[email protected]>

* keep user hint height and pos constant

Signed-off-by: Paul Sebastian <[email protected]>

* fix issue where identifiers would suggest twice, after WS

Signed-off-by: Paul Sebastian <[email protected]>

* add some priority based tokens to appear at the top

Signed-off-by: Paul Sebastian <[email protected]>

* reenable plus and minus for sort command

Signed-off-by: Paul Sebastian <[email protected]>

* Changeset file for PR #8087 created/updated

* update user hints

Signed-off-by: Paul Sebastian <[email protected]>

* update types

Signed-off-by: Paul Sebastian <[email protected]>

---------

Signed-off-by: Paul Sebastian <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 8118024)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 20, 2024
Merged
ashwin-pc pushed a commit that referenced this pull request Sep 21, 2024
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @abbyhu2000
[Auto Suggest] PPL autocomplete fixes (#8087) (#8260)
d21c4d9 
* add stats agg functions and insert snippet rules



* allow table suggestions with table name



* stop suggestion search from filter



* keep user hint height and pos constant



* fix issue where identifiers would suggest twice, after WS



* add some priority based tokens to appear at the top



* reenable plus and minus for sort command



* Changeset file for PR #8087 created/updated

* update user hints



* update types



---------



(cherry picked from commit 8118024)

Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Qingyang(Abby) Hu <[email protected]>
abbyhu2000 added a commit to abbyhu2000/OpenSearch-Dashboards that referenced this pull request Sep 24, 2024
@abbyhu2000
Revert "[Auto Suggest] PPL autocomplete fixes (opensearch-project#8087)…
ab87e54 
… (opensearch-project#8260)"

This reverts commit d21c4d9.
@joshuali925 joshuali925 mentioned this pull request Nov 12, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sejli sejli sejli approved these changes

@joshuali925 joshuali925 joshuali925 approved these changes

@kavilla kavilla kavilla approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
2.17.1 backport 2.x backport 2.17 discover for discover reinvent valued-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paulstn @kavilla @ashwin-pc @joshuali925 @sejli