-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: order of query editor extensions not working #8045
fix: order of query editor extensions not working #8045
Conversation
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
@joshuali925 @kavilla @ashwin-pc Could you take a look at this bug fix please, thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8045 +/- ##
==========================================
- Coverage 60.60% 60.59% -0.02%
==========================================
Files 3732 3732
Lines 88427 88430 +3
Branches 13701 13701
==========================================
- Hits 53589 53580 -9
- Misses 31579 31590 +11
- Partials 3259 3260 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
* fix: order it query editor extensions not working Signed-off-by: Yulong Ruan <[email protected]> * tweaks query assist extension styles Signed-off-by: Yulong Ruan <[email protected]> * Changeset file for PR #8045 created/updated --------- Signed-off-by: Yulong Ruan <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit cedba8e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix: order it query editor extensions not working Signed-off-by: Yulong Ruan <[email protected]> * tweaks query assist extension styles Signed-off-by: Yulong Ruan <[email protected]> * Changeset file for PR #8045 created/updated --------- Signed-off-by: Yulong Ruan <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit cedba8e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix: order it query editor extensions not working * tweaks query assist extension styles * Changeset file for PR #8045 created/updated --------- (cherry picked from commit cedba8e) Signed-off-by: Yulong Ruan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
* fix: order it query editor extensions not working * tweaks query assist extension styles * Changeset file for PR #8045 created/updated --------- (cherry picked from commit cedba8e) Signed-off-by: Yulong Ruan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
When the react portal was created asynchronously within the same container, the order of query editor extensions cannot not be guaranteed. As react portal append the rendered component to the same container at the time when it's mounted. To fix the issue, now rendering the extension to different pre-ordered container.
This PR also introduced a few style changes so that multiple extensions can be render horizontally:
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration