Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport 2.x] [discover] async query and caching (#7943) #7979

Merged
merged 1 commit into from
Sep 3, 2024
Merged

[backport 2.x] [discover] async query and caching (#7943) #7979

merged 1 commit into from
Sep 3, 2024

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Sep 3, 2024 •
edited
Loading

Backport of 8c9abe2 from #7943

@kavilla
[discover] async query and caching (opensearch-project#7943)
a3507ef 
Async query feature for S3 type on Discover. Due to the time to click and verify I end up implementing the cache to avoid waiting too long per every re-build.

What this PR does:

    Poll for query
    Cache data structures and refetches them from session storage
    Poll based on the data type

What this PR does NOT do yet:

    SessionId for search strategy, working fine for selector
    isCacheable field property
    Abort signal on server

---------

Signed-off-by: Kawika Avilla <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 8c9abe2)
@kavilla kavilla changed the title [discover] async query and caching (#7943) [backport 2.x] [discover] async query and caching (#7943) Sep 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@kavilla kavilla added discover for discover reinvent v2.17.0 and removed failed changeset labels Sep 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Sep 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.33333% with 56 lines in your changes missing coverage. Please review.

Project coverage is 61.13%. Comparing base (70620e2) to head (a3507ef).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
src/plugins/query_enhancements/common/utils.ts 20.00% 16 Missing ⚠️
...gins/query_enhancements/public/datasets/s3_type.ts 6.66% 14 Missing ⚠️
...ry/query_string/dataset_service/dataset_service.ts 52.17% 9 Missing and 2 partials ⚠️
...c/plugins/query_enhancements/server/utils/facet.ts 0.00% 9 Missing ⚠️
.../data/common/search/search_source/search_source.ts 0.00% 4 Missing ⚠️
src/plugins/data/public/plugin.ts 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #7979      +/-   ##
==========================================
+ Coverage   61.06%   61.13%   +0.07%     
==========================================
  Files        3683     3686       +3     
  Lines       87060    87137      +77     
  Branches    13373    13382       +9     
==========================================
+ Hits        53163    53274     +111     
+ Misses      30687    30633      -54     
- Partials     3210     3230      +20
Flag Coverage Δ
Linux_1 28.80% <0.00%> (-0.02%) ⬇️
Linux_2 56.36% <0.00%> (-0.01%) ⬇️
Linux_3 ?
Linux_4 29.67% <6.66%> (-0.01%) ⬇️
Windows_1 28.82% <0.00%> (-0.02%) ⬇️
Windows_2 56.31% <0.00%> (-0.01%) ⬇️
Windows_3 37.99% <45.16%> (+0.14%) ⬆️
Windows_4 29.67% <6.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kavilla kavilla merged commit 880634f into opensearch-project:2.x Sep 3, 2024
51 of 59 checks passed
@SuZhou-Joe SuZhou-Joe mentioned this pull request Sep 4, 2024
Merged
7 tasks
@AMoo-Miki AMoo-Miki mentioned this pull request Sep 13, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sejli sejli sejli approved these changes

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
discover for discover reinvent failed changeset v2.17.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kavilla @ashwin-pc @sejli