-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement nested support for histograms aggregations #794
Implement nested support for histograms aggregations #794
Conversation
✅ DCO Check Passed d6cede9 |
There are 5 tests suites failing : It doesn't look related to my feature. |
@tmarkley do we have any bandwidth to help @MerwaneHAMADI this week? |
From your
Can you update the snapshots? |
@tmarkley yes, no problem |
Signed-off-by: Merwane Hamadi <[email protected]>
Signed-off-by: Merwane Hamadi <[email protected]>
d6cede9
to
3b51142
Compare
✅ DCO Check Passed 3b51142 |
Snapshots updated. These are the tests failing. I don't think it's related. |
Thanks for the update @MerwaneHAMADI. Apologies for trying to catch up. Just to clarify, I don't need a custom plugin for this to work? Or would it be required as mentioned in the thread. In the thread you I see you dropped some data and referenced the legacy application. I'm trying to point this to OpenSearch and run it with 'vanilla' OpenSearch Dashboards and not seeing the same results. If it's all working for you, could provide me with some sample data to insert and an example visualization (like the saved object if possible). Thank you. |
@MerwaneHAMADI any feedback from above? |
Hey @MerwaneHAMADI just checking in again. Is there anything we can do to help get this PR merged? |
Hello @MerwaneHAMADI, this pull request has not had activity recently. We will close this in 7 days if no further updates. If it closes by the time you make the requested updates then please re-open the pull request. Thank you! |
Signed-off-by: Merwane Hamadi [email protected]
Description
This change allows the user to select a nested field on all histograms visualizations. This voluntarily a limited scope. I suggest we add more fields in the future. To add another field, all you have to do is change this array :
nestedAggregationsSupported = ['histogram'];
After running a query on a nested field, opensearch dashboard will automatically generate the correct elasticsearch query, send it to elasticsearch and return back nested visualizations.
Issues Resolved
This PR is a part of #657
Check List