Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement nested support for histograms aggregations #794

Conversation

waynehamadi
Copy link
Contributor

Signed-off-by: Merwane Hamadi [email protected]

Description

This change allows the user to select a nested field on all histograms visualizations. This voluntarily a limited scope. I suggest we add more fields in the future. To add another field, all you have to do is change this array :
nestedAggregationsSupported = ['histogram'];
After running a query on a nested field, opensearch dashboard will automatically generate the correct elasticsearch query, send it to elasticsearch and return back nested visualizations.

Issues Resolved

This PR is a part of #657

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed d6cede9

@waynehamadi
Copy link
Contributor Author

There are 5 tests suites failing :
test.txt

It doesn't look related to my feature.

@ahopp
Copy link
Contributor

ahopp commented Sep 21, 2021

@tmarkley do we have any bandwidth to help @MerwaneHAMADI this week?

@kavilla
Copy link
Member

kavilla commented Sep 21, 2021

Screen Shot 2021-09-21 at 9 31 30 AM

@tmarkley
Copy link
Contributor

From your test.txt file:

3 snapshots failed from 2 test suites. Inspect your code changes or run `yarn run test:jest -u` to update them.

Can you update the snapshots?

@waynehamadi
Copy link
Contributor Author

@tmarkley yes, no problem

@kavilla kavilla linked an issue Sep 28, 2021 that may be closed by this pull request
@kavilla kavilla added the enhancement New feature or request label Sep 28, 2021
@tmarkley tmarkley mentioned this pull request Sep 28, 2021
1 task
@waynehamadi waynehamadi force-pushed the feature/nested-aggregations branch from d6cede9 to 3b51142 Compare October 10, 2021 03:50
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 3b51142

@waynehamadi
Copy link
Contributor Author

waynehamadi commented Oct 10, 2021

Snapshots updated. These are the tests failing. I don't think it's related.
tests.txt

@kavilla
Copy link
Member

kavilla commented Oct 11, 2021

Thanks for the update @MerwaneHAMADI. Apologies for trying to catch up.

Just to clarify, I don't need a custom plugin for this to work? Or would it be required as mentioned in the thread.

In the thread you I see you dropped some data and referenced the legacy application. I'm trying to point this to OpenSearch and run it with 'vanilla' OpenSearch Dashboards and not seeing the same results.

If it's all working for you, could provide me with some sample data to insert and an example visualization (like the saved object if possible).

Thank you.

@kavilla
Copy link
Member

kavilla commented Oct 22, 2021

@MerwaneHAMADI any feedback from above?

@tmarkley
Copy link
Contributor

Hey @MerwaneHAMADI just checking in again. Is there anything we can do to help get this PR merged?

@kavilla
Copy link
Member

kavilla commented Dec 12, 2021

Hello @MerwaneHAMADI, this pull request has not had activity recently. We will close this in 7 days if no further updates. If it closes by the time you make the requested updates then please re-open the pull request. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested field support in visualizations
5 participants