refactor: update header description for data source management when in workspace #7916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Invalid PrefixInvalid description prefix. Found "". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test". |
opensearch-changeset-bot bot
added a commit
to raintygao/OpenSearch-Dashboards
that referenced
this pull request
Aug 29, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7916 +/- ##
==========================================
- Coverage 64.33% 64.33% -0.01%
==========================================
Files 3677 3677
Lines 81206 81203 -3
Branches 12946 12947 +1
==========================================
- Hits 52243 52239 -4
- Misses 25750 25751 +1
Partials 3213 3213
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
…tent is translated which causes the comparison to fail in CI env Signed-off-by: tygao <[email protected]>
raintygao
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn and
SuZhou-Joe
as code owners
raintygao
requested review from
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
ruanyl
approved these changes
Sep 2, 2024
SuZhou-Joe
approved these changes
Sep 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 2, 2024
…n workspace (#7916) * feat: update header description for dsm when in workspace Signed-off-by: tygao <[email protected]> * Changeset file for PR #7916 created/updated * Changeset file for PR #7916 created/updated * test: update snapshots Signed-off-by: tygao <[email protected]> * test: recover snapshot Signed-off-by: tygao <[email protected]> * test: commit transpiled snapshot Signed-off-by: tygao <[email protected]> * test: update render method in test to avoid the slash in snapshot content is translated which causes the comparison to fail in CI env Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit c9c672a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Sep 3, 2024
…n workspace (#7916) (#7956) * feat: update header description for dsm when in workspace * Changeset file for PR #7916 created/updated * Changeset file for PR #7916 created/updated * test: update snapshots * test: recover snapshot * test: commit transpiled snapshot * test: update render method in test to avoid the slash in snapshot content is translated which causes the comparison to fail in CI env --------- (cherry picked from commit c9c672a) Signed-off-by: tygao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update header description for data source management when in workspace
Screenshot
out of workspace
in workspace
Testing the changes
Entrer a workspace and go to data source page
Changelog
Check List
yarn test:jestyarn test:jest_integration