Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update oui to 1.12 #7865

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

virajsanghvi
Copy link
Collaborator

@virajsanghvi virajsanghvi commented Aug 27, 2024

Description

Updates oui to get latest updates

Issues Resolved

N/A

Screenshot

N/A

Testing the changes

Validated things build

Changelog

  • chore: Update oui to 1.12

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Viraj Sanghvi <[email protected]>
dependencies:
emoji-regex "^8.0.0"
is-fullwidth-code-point "^3.0.0"
strip-ansi "^6.0.1"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like these were split up due to different transient dependencies. I just ran yarn osd bootstrap to generate - lmk if there's a better way.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.17%. Comparing base (1976ecf) to head (d0e96ea).
Report is 146 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7865   +/-   ##
=======================================
  Coverage   64.17%   64.17%           
=======================================
  Files        3659     3659           
  Lines       80796    80796           
  Branches    12866    12866           
=======================================
  Hits        51848    51848           
  Misses      25769    25769           
  Partials     3179     3179           
Flag Coverage Δ
Linux_1 30.30% <ø> (ø)
Linux_2 55.89% <ø> (ø)
Linux_3 40.67% <ø> (ø)
Linux_4 31.46% <ø> (ø)
Windows_1 30.32% <ø> (ø)
Windows_2 55.85% <ø> (ø)
Windows_3 40.67% <ø> (+<0.01%) ⬆️
Windows_4 31.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@virajsanghvi virajsanghvi merged commit 727c479 into opensearch-project:main Aug 27, 2024
73 of 74 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 27, 2024
Signed-off-by: Viraj Sanghvi <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 727c479)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
virajsanghvi pushed a commit that referenced this pull request Aug 27, 2024
(cherry picked from commit 727c479)

Signed-off-by: Viraj Sanghvi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants