Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query assistant fetching agent bug #7804

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

chishui
Copy link
Contributor

@chishui chishui commented Aug 22, 2024

Description

Fix bug #7803

Issues Resolved

#7803

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 7804.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

Signed-off-by: Liyun Xiu <[email protected]>
Signed-off-by: Liyun Xiu <[email protected]>
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.82%. Comparing base (3a41f7b) to head (c604baf).
Report is 7 commits behind head on main.

Files Patch % Lines
..._enhancements/server/routes/query_assist/agents.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7804      +/-   ##
==========================================
+ Coverage   63.80%   63.82%   +0.02%     
==========================================
  Files        3656     3658       +2     
  Lines       81210    81270      +60     
  Branches    12950    12967      +17     
==========================================
+ Hits        51812    51869      +57     
- Misses      26217    26219       +2     
- Partials     3181     3182       +1     
Flag Coverage Δ
Linux_1 30.14% <ø> (+0.06%) ⬆️
Linux_2 55.87% <ø> (ø)
Linux_3 40.41% <ø> (-0.01%) ⬇️
Linux_4 31.29% <75.00%> (+<0.01%) ⬆️
Windows_1 30.16% <ø> (+0.06%) ⬆️
Windows_2 55.82% <ø> (ø)
Windows_3 40.42% <ø> (ø)
Windows_4 31.29% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

joshuali925
joshuali925 previously approved these changes Aug 22, 2024
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't know ml-commons API had this breaking change, thanks

Signed-off-by: Liyun Xiu <[email protected]>
@SuZhou-Joe SuZhou-Joe merged commit 3364d0c into opensearch-project:main Aug 23, 2024
71 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 23, 2024
* Fix query assistant fetching agent bug

Signed-off-by: Liyun Xiu <[email protected]>

* Add changelog

Signed-off-by: Liyun Xiu <[email protected]>

* fix style

Signed-off-by: Liyun Xiu <[email protected]>

* Add UT

Signed-off-by: Liyun Xiu <[email protected]>

---------

Signed-off-by: Liyun Xiu <[email protected]>
(cherry picked from commit 3364d0c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Aug 26, 2024
* Fix query assistant fetching agent bug



* Add changelog



* fix style



* Add UT



---------


(cherry picked from commit 3364d0c)

Signed-off-by: Liyun Xiu <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants