[navigation]feat: add home icon in left bottom #7802

SuZhou-Joe · 2024-08-22T08:04:21Z

Description

Add home icon in left bottom and remove home in left nav as we already have the icon in left bottom.
Make bottom container scrollable
Move workspace settings to manage workspace category

Issues Resolved

Screenshot

Home icon in left bottom

Make left bottom container scrollable

Add workspace settings under manage workspace category

Testing the changes

Changelog

feat: add home icon in left bottom

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

codecov · 2024-08-22T08:26:06Z

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.83%. Comparing base (a59f8ab) to head (65c38c5).
Report is 12 commits behind head on main.

Files	Patch %	Lines
src/plugins/home/public/plugin.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7802   +/-   ##
=======================================
  Coverage   63.83%   63.83%           
=======================================
  Files        3658     3659    +1     
  Lines       81284    81282    -2     
  Branches    12972    12972           
=======================================
+ Hits        51884    51887    +3     
+ Misses      26216    26215    -1     
+ Partials     3184     3180    -4

Flag	Coverage Δ
Linux_1	`30.16% <0.00%> (+<0.01%)`	⬆️
Linux_2	`55.87% <ø> (ø)`
Linux_3	`40.41% <0.00%> (-0.01%)`	⬇️
Linux_4	`31.29% <50.00%> (+<0.01%)`	⬆️
Windows_1	`30.18% <0.00%> (+<0.01%)`	⬆️
Windows_2	`55.82% <ø> (ø)`
Windows_3	`40.41% <0.00%> (-0.01%)`	⬇️
Windows_4	`31.29% <50.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx

AMoo-Miki · 2024-08-22T15:52:31Z

src/core/public/chrome/ui/header/collapsible_nav_group_enabled.tsx

@@ -435,6 +435,7 @@ export function CollapsibleNavGroupEnabled({
        <div
          className={classNames({
            'bottom-container': true,
+            'eui-xScroll': true,


How will this look on browser-OS combos that show a scrollbar?

I get your point, I thought the class will help to hide the scrollbar, but if not, let me find if there is any pattern code I can follow in OSD.

Seem behavior of adding the utility css class follows the OS settings. Was the intention to hide the scrollbar but allow user to scroll?

I added -ms-overflow-style: -ms-autohiding-scrollbar; to the bottom container to make the behavior of scrollbar consistent. Do you think that's good enough?

I'm fine with it, UX need to figure out how to fit those overflow icons, I think we can optimize this afterwards.

src/plugins/home/public/application/components/home_icon.tsx

ruanyl · 2024-08-23T01:54:44Z

src/core/public/chrome/ui/header/collapsible_nav_group_enabled.tsx

@@ -435,6 +435,7 @@ export function CollapsibleNavGroupEnabled({
        <div
          className={classNames({
            'bottom-container': true,
+            'eui-xScroll': true,


Seem behavior of adding the utility css class follows the OS settings. Was the intention to hide the scrollbar but allow user to scroll?

Signed-off-by: SuZhou-Joe <[email protected]>

src/plugins/visualize/public/plugin.ts

Signed-off-by: SuZhou-Joe <[email protected]>

opensearch-trigger-bot · 2024-08-23T16:34:59Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7802-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 106b64cd1e85df979fa8b78269b25f10057d284c
# Push it to GitHub
git push --set-upstream origin backport/backport-7802-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7802-to-2.x.

opensearch-trigger-bot · 2024-08-26T01:08:53Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7802-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 106b64cd1e85df979fa8b78269b25f10057d284c
# Push it to GitHub
git push --set-upstream origin backport/backport-7802-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7802-to-2.x.

* feat: add home icon in left bottom Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless padding Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR opensearch-project#7802 created/updated * fix: update snapshot Signed-off-by: SuZhou-Joe <[email protected]> * feat: use flush Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize style Signed-off-by: SuZhou-Joe <[email protected]> * feat: move features around in nav group Signed-off-by: SuZhou-Joe <[email protected]> * fix: typo Signed-off-by: SuZhou-Joe <[email protected]> * fix: unit test Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 106b64c)

…7836) * [navigation]feat: add home icon in left bottom (#7802) * feat: add home icon in left bottom Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless padding Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #7802 created/updated * fix: update snapshot Signed-off-by: SuZhou-Joe <[email protected]> * feat: use flush Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize style Signed-off-by: SuZhou-Joe <[email protected]> * feat: move features around in nav group Signed-off-by: SuZhou-Joe <[email protected]> * fix: typo Signed-off-by: SuZhou-Joe <[email protected]> * fix: unit test Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 106b64c) * fix: unit test error Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>

AMoo-Miki · 2024-09-10T16:30:49Z

Manually backported with #7802

github-actions bot added the distinguished-contributor label Aug 22, 2024

SuZhou-Joe force-pushed the feature/add-home-icon branch from d2f284c to e1b726b Compare August 22, 2024 08:04

github-actions bot added the failed changeset label Aug 22, 2024

SuZhou-Joe added backport 2.x v2.17.0 navigation labels Aug 22, 2024

github-actions bot removed the failed changeset label Aug 22, 2024

opensearch-changeset-bot bot added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Aug 22, 2024

Changeset file for PR opensearch-project#7802 created/updated

cc16852

opensearch-project deleted a comment from github-actions bot Aug 22, 2024

SuZhou-Joe marked this pull request as ready for review August 22, 2024 08:13

SuZhou-Joe requested review from ananzh, kavilla, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, curq, bandinib-amzn, ruanyl, BionIT, xinruiba, zhyuanqi, mengweieric, LDrago27 and virajsanghvi as code owners August 22, 2024 08:13

AMoo-Miki reviewed Aug 22, 2024

View reviewed changes

src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx Outdated Show resolved Hide resolved

AMoo-Miki reviewed Aug 22, 2024

View reviewed changes

ruanyl reviewed Aug 23, 2024

View reviewed changes

SuZhou-Joe and others added 7 commits August 23, 2024 11:01

feat: add home icon in left bottom

5c4590f

Signed-off-by: SuZhou-Joe <[email protected]>

feat: remove useless padding

a846e47

Signed-off-by: SuZhou-Joe <[email protected]>

Changeset file for PR opensearch-project#7802 created/updated

b8f8cd8

fix: update snapshot

2101eac

Signed-off-by: SuZhou-Joe <[email protected]>

feat: use flush

1e9b70e

Signed-off-by: SuZhou-Joe <[email protected]>

feat: optimize style

d9e54e7

Signed-off-by: SuZhou-Joe <[email protected]>

feat: move features around in nav group

c7b6c35

Signed-off-by: SuZhou-Joe <[email protected]>

SuZhou-Joe force-pushed the feature/add-home-icon branch from 663ae7b to c7b6c35 Compare August 23, 2024 03:02

Hailong-am reviewed Aug 23, 2024

View reviewed changes

src/plugins/visualize/public/plugin.ts Outdated Show resolved Hide resolved

fix: typo

1baa672

Signed-off-by: SuZhou-Joe <[email protected]>

ruanyl previously approved these changes Aug 23, 2024

View reviewed changes

fix: unit test

65c38c5

Signed-off-by: SuZhou-Joe <[email protected]>

SuZhou-Joe dismissed ruanyl’s stale review via 65c38c5 August 23, 2024 06:05

ruanyl approved these changes Aug 23, 2024

View reviewed changes

ananzh approved these changes Aug 23, 2024

View reviewed changes

SuZhou-Joe merged commit 106b64c into opensearch-project:main Aug 23, 2024
66 of 67 checks passed

opensearch-trigger-bot bot added the failed backport label Aug 23, 2024

SuZhou-Joe added backport 2.x and removed backport 2.x labels Aug 26, 2024

SuZhou-Joe mentioned this pull request Aug 26, 2024

[Backport 2.x][navigation]feat: add home icon in left bottom (#7802) #7836

Merged

7 tasks

AMoo-Miki removed the failed backport label Sep 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[navigation]feat: add home icon in left bottom #7802

[navigation]feat: add home icon in left bottom #7802

SuZhou-Joe commented Aug 22, 2024 •

edited

Loading

codecov bot commented Aug 22, 2024 •

edited

Loading

AMoo-Miki Aug 22, 2024

SuZhou-Joe Aug 23, 2024

ruanyl Aug 23, 2024

SuZhou-Joe Aug 23, 2024 •

edited

Loading

ruanyl Aug 23, 2024

ruanyl Aug 23, 2024

opensearch-trigger-bot bot commented Aug 23, 2024

opensearch-trigger-bot bot commented Aug 26, 2024

AMoo-Miki commented Sep 10, 2024

[navigation]feat: add home icon in left bottom #7802

[navigation]feat: add home icon in left bottom #7802

Conversation

SuZhou-Joe commented Aug 22, 2024 • edited Loading

Description

Issues Resolved

Screenshot

Home icon in left bottom

Make left bottom container scrollable

Add workspace settings under manage workspace category

Testing the changes

Changelog

Check List

codecov bot commented Aug 22, 2024 • edited Loading

Codecov Report

AMoo-Miki Aug 22, 2024

Choose a reason for hiding this comment

SuZhou-Joe Aug 23, 2024

Choose a reason for hiding this comment

ruanyl Aug 23, 2024

Choose a reason for hiding this comment

SuZhou-Joe Aug 23, 2024 • edited Loading

Choose a reason for hiding this comment

ruanyl Aug 23, 2024

Choose a reason for hiding this comment

ruanyl Aug 23, 2024

Choose a reason for hiding this comment

opensearch-trigger-bot bot commented Aug 23, 2024

opensearch-trigger-bot bot commented Aug 26, 2024

AMoo-Miki commented Sep 10, 2024

SuZhou-Joe commented Aug 22, 2024 •

edited

Loading

codecov bot commented Aug 22, 2024 •

edited

Loading

SuZhou-Joe Aug 23, 2024 •

edited

Loading