[Workspace] feat: Add workspace navigation for default route #7785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yubonluo <[email protected]>
yubonluo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7785 +/- ##
==========================================
- Coverage 63.83% 63.83% -0.01%
==========================================
Files 3658 3658
Lines 81284 81311 +27
Branches 12972 12978 +6
==========================================
+ Hits 51884 51901 +17
- Misses 26216 26226 +10
Partials 3184 3184
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
reviewed
Aug 21, 2024
SuZhou-Joe
reviewed
Aug 21, 2024
SuZhou-Joe
reviewed
Aug 21, 2024
src/plugins/workspace/public/components/workspace_navigation_app.tsx
Outdated
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Aug 21, 2024
src/plugins/workspace/public/components/workspace_initial/workspace_initial.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: yubonluo <[email protected]>
…enSearch-Dashboards into 2.17/workspace-default-route
AMoo-Miki
reviewed
Aug 22, 2024
src/plugins/workspace/public/components/workspace_initial/workspace_initial.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: yubonluo <[email protected]>
AMoo-Miki
reviewed
Aug 22, 2024
AMoo-Miki
reviewed
Aug 22, 2024
…oards into 2.17/workspace-default-route
SuZhou-Joe
reviewed
Aug 22, 2024
Hailong-am
reviewed
Aug 22, 2024
…oards into 2.17/workspace-default-route
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
ruanyl
approved these changes
Aug 23, 2024
| @@ -375,6 +377,32 @@ export class WorkspacePlugin | |||
| workspaceAvailability: WorkspaceAvailability.outsideWorkspace, | |||
| }); | |||
|
|
|||
| const registeredUseCases$ = this.registeredUseCases$; | |||
| // register workspace navigation | |||
There was a problem hiding this comment.
Would be nice to have a more context about this change
SuZhou-Joe
approved these changes
Aug 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
* add workspace navigation Signed-off-by: yubonluo <[email protected]> * Changeset file for PR #7785 created/updated * optimize the code Signed-off-by: yubonluo <[email protected]> * optimize the code Signed-off-by: yubonluo <[email protected]> * optimize the test code and add newHomePage check Signed-off-by: yubonluo <[email protected]> * delete useless code Signed-off-by: yubonluo <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit e1e8169) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Aug 26, 2024
…7824) * add workspace navigation * Changeset file for PR #7785 created/updated * optimize the code * optimize the code * optimize the test code and add newHomePage check * delete useless code --------- (cherry picked from commit e1e8169) Signed-off-by: yubonluo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add workspace navigation for default route to handle the following cases:
Issues Resolved
#7783
Screenshot
2024-08-21.17.49.34.mp4
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration