-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Manual Backport 2.x] feat: Add V9 Theme (#7757) #7775
[Manual Backport 2.x] feat: Add V9 Theme (#7757) #7775
Conversation
❌ Invalid Additional Prefix With Skip Entry OptionIf your Changelog section includes the 'skip' entry option, it cannot also include other changelog entry prefixes. The option 'skip' must be alone when used. Please review your Changelog section again. |
❌ Invalid Additional Prefix With Skip Entry OptionIf your Changelog section includes the 'skip' entry option, it cannot also include other changelog entry prefixes. The option 'skip' must be alone when used. Please review your Changelog section again. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7775 +/- ##
=======================================
Coverage 63.86% 63.87%
=======================================
Files 3653 3655 +2
Lines 80992 81045 +53
Branches 12885 12894 +9
=======================================
+ Hits 51728 51769 +41
- Misses 26099 26107 +8
- Partials 3165 3169 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* feat: Add V9 Theme --------- Signed-off-by: Viraj Sanghvi <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 9d3ca79)
74b3519
to
78649ff
Compare
Description
Manual backport as user specific themes wasn't on 2.x causing some changes.
Main difference of this is that changes in ui_render_mixin (https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7757/files#diff-b524e9b1aa714d4d29d9295214b20ea793c69d8e254203c623d32fe13a14d972) are now in
src/core/server/rendering/views/fonts.tsx
andsrc/core/server/rendering/views/theme.ts
. Also included a docs update to document difference.Issues Resolved
N/A
Screenshot
N/A
Testing the changes
Tested this locally and changing theme in advanced settings has expected behavior (and correct files load).
Changelog
Check List
yarn test:jest
yarn test:jest_integration