Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport 2.x] feat: Add V9 Theme (#7757) #7775

Conversation

virajsanghvi
Copy link
Collaborator

@virajsanghvi virajsanghvi commented Aug 20, 2024

Description

Manual backport as user specific themes wasn't on 2.x causing some changes.

Main difference of this is that changes in ui_render_mixin (https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7757/files#diff-b524e9b1aa714d4d29d9295214b20ea793c69d8e254203c623d32fe13a14d972) are now in src/core/server/rendering/views/fonts.tsx and src/core/server/rendering/views/theme.ts. Also included a docs update to document difference.

Issues Resolved

N/A

Screenshot

N/A

Testing the changes

Tested this locally and changing theme in advanced settings has expected behavior (and correct files load).

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Invalid Additional Prefix With Skip Entry Option

If your Changelog section includes the 'skip' entry option, it cannot also include other changelog entry prefixes. The option 'skip' must be alone when used. Please review your Changelog section again.

Copy link
Contributor

❌ Invalid Additional Prefix With Skip Entry Option

If your Changelog section includes the 'skip' entry option, it cannot also include other changelog entry prefixes. The option 'skip' must be alone when used. Please review your Changelog section again.

@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.87%. Comparing base (1987d5c) to head (78649ff).
Report is 2 commits behind head on 2.x.

Files Patch % Lines
src/core/server/ui_settings/settings/theme.ts 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #7775   +/-   ##
=======================================
  Coverage   63.86%   63.87%           
=======================================
  Files        3653     3655    +2     
  Lines       80992    81045   +53     
  Branches    12885    12894    +9     
=======================================
+ Hits        51728    51769   +41     
- Misses      26099    26107    +8     
- Partials     3165     3169    +4     
Flag Coverage Δ
Linux_1 30.10% <23.07%> (-0.02%) ⬇️
Linux_2 55.95% <92.30%> (-0.03%) ⬇️
Linux_3 40.52% <23.07%> (-0.02%) ⬇️
Linux_4 31.46% <23.07%> (-0.03%) ⬇️
Windows_1 30.12% <23.07%> (?)
Windows_2 55.91% <92.30%> (-0.03%) ⬇️
Windows_3 40.53% <23.07%> (?)
Windows_4 31.46% <23.07%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* feat: Add V9 Theme
---------

Signed-off-by: Viraj Sanghvi <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 9d3ca79)
@virajsanghvi virajsanghvi merged commit 3835fc2 into opensearch-project:2.x Aug 20, 2024
64 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants