[Workspace]fix the parameter misalignment error in the workspace_detail_page #7768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qxisylolo <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7768 +/- ##
==========================================
- Coverage 63.82% 63.82% -0.01%
==========================================
Files 3655 3655
Lines 81117 81117
Branches 12921 12921
==========================================
- Hits 51772 51770 -2
- Misses 26167 26168 +1
- Partials 3178 3179 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Qxisylolo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
SuZhou-Joe
approved these changes
Aug 20, 2024
ruanyl
approved these changes
Aug 20, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
…il_page (#7768) * fix the argument error in the workspace_detail_page Signed-off-by: Qxisylolo <[email protected]> * Changeset file for PR #7768 created/updated --------- Signed-off-by: Qxisylolo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit b46a34d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 21, 2024
…il_page (#7768) (#7772) * fix the argument error in the workspace_detail_page * Changeset file for PR #7768 created/updated --------- (cherry picked from commit b46a34d) Signed-off-by: Qxisylolo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr address the bug in the workspace_detail_page, which due to the change of parameter declaration in delete_workspace_modal
Changelog
Check List
yarn test:jestyarn test:jest_integration