Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workspace] Support workspace initial page #7708

Merged
merged 7 commits into from
Aug 20, 2024
Merged

[Workspace] Support workspace initial page #7708

merged 7 commits into from
Aug 20, 2024

Conversation

yubonluo
Copy link
Contributor

Description

Support workspace initial page.

  • If login user has no workspace, it would show the initial page
  • If login user has more than one workspaces, it would not show the initial page
  • Dashboard admin can click the create workspace button
  • Create workspace button do not been shown for non admin user

Issues Resolved

#7707

Screenshot

2024-08-14.14.30.46.mp4

Testing the changes

  1. Clone the latest osd code and run yarn osd bootstrap
  2. Modify config/opensearch_dashboards.yml
workspace.enabled: true 
uiSettings:
  overrides:
    "home:useNewHomePage": true
  1. Run yarn start --no-base-path
  2. Input url http://localhost:5601

Changelog

  • feat: Support workspace initial page

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov Codecov
Copy link

codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.83%. Comparing base (6877bea) to head (5fac3d7).
Report is 191 commits behind head on main.

Files with missing lines Patch % Lines
src/plugins/workspace/public/plugin.ts 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7708      +/-   ##
==========================================
+ Coverage   63.81%   63.83%   +0.02%     
==========================================
  Files        3651     3652       +1     
  Lines       80954    81021      +67     
  Branches    12893    12900       +7     
==========================================
+ Hits        51662    51721      +59     
- Misses      26126    26132       +6     
- Partials     3166     3168       +2
Flag Coverage Δ
Linux_1 30.10% <93.10%> (?)
Linux_2 55.89% <ø> (+0.05%) ⬆️
Linux_3 40.44% <ø> (+0.02%) ⬆️
Linux_4 31.31% <ø> (+0.02%) ⬆️
Windows_1 30.11% <93.10%> (+0.06%) ⬆️
Windows_2 55.85% <ø> (+0.05%) ⬆️
Windows_3 40.44% <ø> (+0.02%) ⬆️
Windows_4 31.31% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl added the v2.17.0 label Aug 15, 2024
@SuZhou-Joe
Copy link
Member

@yubonluo Could you please give a screenshot on how the page will look like in dark mode?

@yubonluo
Copy link
Contributor Author

@yubonluo Could you please give a screenshot on how the page will look like in dark mode?
This is the page in the dark mode

image

@SuZhou-Joe
Copy link
Member

Overall LGTM but the dark mode seems a little bit weird, maybe we need a banner for dark mode.

@yubonluo
fix the test error
110b9e3 
Signed-off-by: yubonluo <[email protected]>
@yubonluo
solve the code conflict
1e1f989 
Signed-off-by: yubonluo <[email protected]>
@yubonluo
add dark mode svg url
5fac3d7 
Signed-off-by: yubonluo <[email protected]>
@yubonluo
Copy link
Contributor Author

Overall LGTM but the dark mode seems a little bit weird, maybe we need a banner for dark mode.

The initial has supported dark mode.
image

ruanyl
ruanyl approved these changes Aug 20, 2024
View reviewed changes
src/plugins/workspace/public/components/workspace_initial_app.tsx

export const WorkspaceInitialApp = () => {
return (
<I18nProvider>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: maybe could move I18nProvider to renderInitialApp

@ruanyl ruanyl merged commit 9aeebec into opensearch-project:main Aug 20, 2024
67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 20, 2024
@github-actions @opensearch-changeset-bot
[Workspace] Support workspace initial page (#7708)
ed2e2c0 
* Support workspace initial page

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR #7708 created/updated

* optimzie the code

Signed-off-by: yubonluo <[email protected]>

* fix the test error

Signed-off-by: yubonluo <[email protected]>

* add dark mode svg url

Signed-off-by: yubonluo <[email protected]>

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 9aeebec)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 20, 2024
Merged
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 20, 2024
@yubonluo @opensearch-changeset-bot @Qxisylolo
[Workspace] Support workspace initial page (opensearch-project#7708)
dd66ab9 
* Support workspace initial page

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR opensearch-project#7708 created/updated

* optimzie the code

Signed-off-by: yubonluo <[email protected]>

* fix the test error

Signed-off-by: yubonluo <[email protected]>

* add dark mode svg url

Signed-off-by: yubonluo <[email protected]>

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Aug 21, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[Workspace] Support workspace initial page (#7708) (#7767)
a7b08e8 
* Support workspace initial page



* Changeset file for PR #7708 created/updated

* optimzie the code



* fix the test error



* add dark mode svg url



---------



(cherry picked from commit 9aeebec)

Signed-off-by: yubonluo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanglam wanglam wanglam left review comments

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ruanyl ruanyl ruanyl approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
backport 2.x in-next seasoned-contributor v2.17.0 workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yubonluo @SuZhou-Joe @ruanyl @wanglam @AMoo-Miki