-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the redesign page and applications headers behind a switch #7637
Introduce the redesign page and applications headers behind a switch #7637
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7637 +/- ##
==========================================
+ Coverage 63.69% 63.73% +0.03%
==========================================
Files 3633 3636 +3
Lines 80135 80393 +258
Branches 12699 12776 +77
==========================================
+ Hits 51043 51236 +193
- Misses 25984 26027 +43
- Partials 3108 3130 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
404bd14
to
18d5aa8
Compare
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Also: * Remove unused code Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
1e9121c
to
ddb9c3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as saved queries cypress failure looks unrelated.
❌ Changeset File Must Not Exist With Skip EntryChangeset file 7637.yml under folder changelogs/fragments must not exist if ##Changelog section in PR description includes a "skip" entry option. Please remove the changeset file and try again. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7637-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 265a176390f337ddc2f3cc20dcd367e77b9abd9f
# Push it to GitHub
git push --set-upstream origin backport/backport-7637-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
…pensearch-project#7637) * Bump OUI to 1.9.0 Signed-off-by: Miki <[email protected]> * Introduce the redesigned page header Signed-off-by: Miki <[email protected]> Update UX of breadcrumbs, menu toggle, and the new contribution points Signed-off-by: Miki <[email protected]> Add renderElement option in HeaderControls Signed-off-by: Shenoy Pratik <[email protected]> Update application mocks and rearrange header layout Signed-off-by: Shenoy Pratik <[email protected]> Break and restyle breadcrumb Signed-off-by: Zhongnan Su <[email protected]> Implement header updates Signed-off-by: Miki <[email protected]> * Introduce HeaderVariant Signed-off-by: Miki <[email protected]> * Organize Header's layout Signed-off-by: Miki <[email protected]> * Fix header control spacing Signed-off-by: Miki <[email protected]> * Conditionally append breadcrumb to recent popover Fix mock for recent items Co-authored-by: Zhongnan Su <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> * Update top nav render and add app header Use ScreenTitle instead of appname from topnav menu Signed-off-by: Shenoy Pratik <[email protected]> * Compress QueryStringInput appearance Signed-off-by: Miki <[email protected]> * Update header for applications Signed-off-by: Miki <[email protected]> * Eliminate colors from the borders of grouped action menu items Signed-off-by: Miki <[email protected]> * Update TopNavControl*Data type to controlType for consistency Signed-off-by: Miki <[email protected]> * Add tests for chrome Header Signed-off-by: Shenoy Pratik <[email protected]> * Update Breadcrumbs tests Signed-off-by: Shenoy Pratik <[email protected]> * Add tests for HeaderControlsContainer Signed-off-by: Miki <[email protected]> * Add tests for TopNavControls and TopNavControlItem Signed-off-by: Shenoy Pratik <[email protected]> * Updated tests for TopNavMenu and TopNavMenuItem Signed-off-by: Shenoy Pratik <[email protected]> * Fix `uiSettingsServiceMock` missing `start` Signed-off-by: Miki <[email protected]> * Add the `target` property to TopNavControlItem Signed-off-by: Miki <[email protected]> * Update Navigation mock and start contract Signed-off-by: Miki <[email protected]> * Add createGetterSetter mock in dashboards app state Signed-off-by: Shenoy Pratik <[email protected]> * Add tests for setting and unsetting header variant Signed-off-by: Miki <[email protected]> * Add tests for setting header controls Signed-off-by: Miki <[email protected]> * Re-skin DataSource selection's trigger button Signed-off-by: Miki <[email protected]> * Conditionally change where theme management menu item shows up Signed-off-by: Miki <[email protected]> * Conditionally change where the help menu items shows up Signed-off-by: Miki <[email protected]> * Make IndexPatternTable page conditionally use the new page header Signed-off-by: Miki <[email protected]> * Make Discover conditionally use the new application header Signed-off-by: Miki <[email protected]> * Make Dashboards conditionally use the new application header Signed-off-by: Miki <[email protected]> * Add changelog fragment Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Miki <[email protected]> * Add tracking issue for empty label for DataSourceMenuPopoverButton Signed-off-by: Miki <[email protected]> * Use EUI aliases in CSS variables Signed-off-by: Miki <[email protected]> * Remove TopNavMenuLink Signed-off-by: Miki <[email protected]> * Make sure OuiHeader doesn't contribute to the background Also: * Remove unused code Signed-off-by: Miki <[email protected]> * Better border hiding for DSM popover button Signed-off-by: Miki <[email protected]> * Make popover button overflow later Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: Zhongnan Su <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> (cherry picked from commit 265a176) Signed-off-by: Miki <[email protected]>
…7637) (#7692) * Bump OUI to 1.9.0 * Introduce the redesigned page header Update UX of breadcrumbs, menu toggle, and the new contribution points Add renderElement option in HeaderControls Update application mocks and rearrange header layout Break and restyle breadcrumb Implement header updates * Introduce HeaderVariant * Organize Header's layout * Fix header control spacing * Conditionally append breadcrumb to recent popover Fix mock for recent items * Update top nav render and add app header Use ScreenTitle instead of appname from topnav menu * Compress QueryStringInput appearance * Update header for applications * Eliminate colors from the borders of grouped action menu items * Update TopNavControl*Data type to controlType for consistency * Add tests for chrome Header * Update Breadcrumbs tests * Add tests for HeaderControlsContainer * Add tests for TopNavControls and TopNavControlItem * Updated tests for TopNavMenu and TopNavMenuItem * Fix `uiSettingsServiceMock` missing `start` * Add the `target` property to TopNavControlItem * Update Navigation mock and start contract * Add createGetterSetter mock in dashboards app state * Add tests for setting and unsetting header variant * Add tests for setting header controls * Re-skin DataSource selection's trigger button * Conditionally change where theme management menu item shows up * Conditionally change where the help menu items shows up * Make IndexPatternTable page conditionally use the new page header * Make Discover conditionally use the new application header * Make Dashboards conditionally use the new application header * Add changelog fragment * Add tracking issue for empty label for DataSourceMenuPopoverButton * Use EUI aliases in CSS variables * Remove TopNavMenuLink * Make sure OuiHeader doesn't contribute to the background Also: * Remove unused code * Better border hiding for DSM popover button * Make popover button overflow later --------- (cherry picked from commit 265a176) Signed-off-by: Miki <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: Zhongnan Su <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]>
Description
Introduce the redesign page and applications headers behind a switch
Also:
Changelog
Check List
yarn test:jest
yarn test:jest_integration