Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation]feat: replace analytics nav group with essentials #7618

Merged

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Aug 5, 2024

Description

For 2.17, we are using

  • essentials to replace analytics.
  • Analytics (All) to replace all.

Issues Resolved

Screenshot

image

Before the change

image

After the change

image

Testing the changes

Changelog

  • feat: use essentials as the nav group name

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@SuZhou-Joe SuZhou-Joe changed the title [navigation]feat: use essentials as the nav group name [navigation]feat: replace analytics nav group with essentials Aug 5, 2024
opensearch-changeset-bot bot added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.67%. Comparing base (ca89488) to head (3e5b1d5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7618   +/-   ##
=======================================
  Coverage   63.67%   63.67%           
=======================================
  Files        3633     3633           
  Lines       80105    80105           
  Branches    12693    12693           
=======================================
  Hits        51009    51009           
  Misses      25987    25987           
  Partials     3109     3109           
Flag Coverage Δ
Linux_1 30.59% <0.00%> (ø)
Linux_2 55.58% <ø> (ø)
Linux_3 40.55% <60.00%> (-0.01%) ⬇️
Linux_4 31.30% <50.00%> (ø)
Windows_1 30.61% <0.00%> (ø)
Windows_2 55.53% <ø> (ø)
Windows_3 40.56% <60.00%> (ø)
Windows_4 31.30% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe force-pushed the fix/change-analytics-name branch from 457d9f5 to 49e7d6b Compare August 7, 2024 08:33
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
@opensearch-project opensearch-project deleted a comment from github-actions bot Aug 7, 2024
@@ -64,16 +64,16 @@ const defaultNavGroups = {
}),
order: 5000,
},
analytics: {
essentials: {
id: 'analytics',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Shall we add some comments here to show why we still using analytics instead of essentials?

@ananzh ananzh merged commit 7bcb949 into opensearch-project:main Aug 8, 2024
68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 9, 2024
* feat: use essentials
* feat: fix home
* feat: change all use case name
* feat: use uppercase
* feat: reserve analytics id
* feat: update title

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 7bcb949)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 12, 2024
…#7668)

* feat: use essentials
* feat: fix home
* feat: change all use case name
* feat: use uppercase
* feat: reserve analytics id
* feat: update title

---------



(cherry picked from commit 7bcb949)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants