Add a util function to generate the relative redirectUrl #7600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuZhou-Joe
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
opensearch-changeset-bot bot
added a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Jul 31, 2024
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
force-pushed
the
feature/add-get-next-url
branch
from
34da2b5
to
9ee89ee
Compare
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7600 +/- ##
=======================================
Coverage 63.64% 63.64%
=======================================
Files 3634 3634
Lines 80099 80104 +5
Branches 12682 12683 +1
=======================================
+ Hits 50977 50984 +7
+ Misses 26015 26014 -1
+ Partials 3107 3106 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruanyl
approved these changes
Aug 2, 2024
ananzh
approved these changes
Aug 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
* feat: add get redirect url function --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit e947ade) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 12, 2024
* feat: add get redirect url function --------- (cherry picked from commit e947ade) Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new util function to
src/core/server/http/http_tools.ts, and the util function should be used by security plugin or other customized authentication plugin to generate the correct redirect url after login.Issues Resolved
partial closes: opensearch-project/security-dashboards-plugin#2069
Screenshot
Only serve side code changes involved.
Testing the changes
The consumer logic is inside opensearch-project/security-dashboards-plugin#2072
Changelog
Check List
yarn test:jestyarn test:jest_integration