-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x manual backport] BP for #7542, #7540, #7552, #7566, #7567 #7574
Conversation
…nsearch-project#7542) * Update datasources fetch function to include local cluster * Check for duplicates when fetching external datasources (in the case local cluster is added as a datasource) * Clean up types in DataSetNavigator so items are displayed properly --------- Signed-off-by: Sean Li <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…ization (opensearch-project#7540) * add max heigh. use memoization Signed-off-by: Kawika Avilla <[email protected]> almost working pretty nicely Signed-off-by: Kawika Avilla <[email protected]> a little bit better Signed-off-by: Kawika Avilla <[email protected]> its ok Signed-off-by: Kawika Avilla <[email protected]> * update mock Signed-off-by: Kawika Avilla <[email protected]> * update another mock Signed-off-by: Kawika Avilla <[email protected]> * fix mock for extension Signed-off-by: Kawika Avilla <[email protected]> * rebase fixes Signed-off-by: Kawika Avilla <[email protected]> * update script Signed-off-by: Kawika Avilla <[email protected]> * fix initial load Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]>
After the following PRs: opensearch-project#7492, opensearch-project#7546, opensearch-project#7540 this commit added skip(1) back to dataset manager observable: fef6156, we need to revert changes done in fix(query assist): update reading data source id from dataset manager opensearch-project#7464 (comment) revert dataset manager observable usage in query assist to support skip(1) revert dataset manager tests [Discover Next] Fixes Discover styles opensearch-project#7546 removed query editor header div, this PR adds it back to enable query editor extensions Signed-off-by: Joshua Li <[email protected]>
…oast (opensearch-project#7566) Signed-off-by: Ashwin P Chandran <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7574 +/- ##
==========================================
- Coverage 63.75% 63.73% -0.03%
==========================================
Files 3628 3628
Lines 79500 79525 +25
Branches 12593 12599 +6
==========================================
Hits 50682 50682
- Misses 25753 25779 +26
+ Partials 3065 3064 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* add back in useeffect for loading databases Signed-off-by: Sean Li <[email protected]> * Changeset file for PR opensearch-project#7567 created/updated --------- Signed-off-by: Sean Li <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Pls don't update branch. The missing one is a workspace PR which is not relevant to these bps. |
Description
This is a backport PR for
Updating fetch functions to include local cluster
#7542
Commit: 7287699
[discover-next][bug] add max height to dataset navigator and use memoization
#7540
Commit: 611f56b
Fix query assist after #7492, #7546, #7540
#7552
Commit: d68c589
[Discover next] Fixes dataset navigator menu styling & search error toast
#7566
Commit: 2b7dbe0
[Discover 2.0] Loading fix for databases
#7567
Commit: 8bafd8d
Issues Resolved
NA
Changelog
Check List
yarn test:jest
yarn test:jest_integration