Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace]Add workspaces and permissions fields into saved objects _bulk_get response #7565

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

Hailong-am
Copy link
Collaborator

Description

this PR will add workspaces and permissions fields into saved objects _bulk_get response

Issues Resolved

#7564

Screenshot

Testing the changes

Changelog

  • fix: [Workspace]Add workspaces and permissions fields into saved objects _bulk_get response

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Hailong Cui <[email protected]>
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.64%. Comparing base (d68c589) to head (f832063).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7565   +/-   ##
=======================================
  Coverage   63.64%   63.64%           
=======================================
  Files        3629     3629           
  Lines       79522    79522           
  Branches    12604    12604           
=======================================
  Hits        50611    50611           
  Misses      25842    25842           
  Partials     3069     3069           
Flag Coverage Δ
Linux_1 30.76% <ø> (ø)
Linux_2 55.58% <ø> (ø)
Linux_3 40.22% <ø> (ø)
Linux_4 31.57% <ø> (ø)
Windows_1 30.77% <ø> (ø)
Windows_2 55.53% <ø> (ø)
Windows_3 40.23% <ø> (ø)
Windows_4 31.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruanyl ruanyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fix!

@SuZhou-Joe SuZhou-Joe merged commit f3dee46 into opensearch-project:main Jul 30, 2024
73 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 30, 2024
…bulk_get response (#7565)

* fix missing fields

Signed-off-by: Hailong Cui <[email protected]>

* Changeset file for PR #7565 created/updated

---------

Signed-off-by: Hailong Cui <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit f3dee46)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 30, 2024
…bulk_get response (#7565)

* fix missing fields

Signed-off-by: Hailong Cui <[email protected]>

* Changeset file for PR #7565 created/updated

---------

Signed-off-by: Hailong Cui <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit f3dee46)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh pushed a commit that referenced this pull request Jul 30, 2024
…bulk_get response (#7565) (#7569)

* fix missing fields
* Changeset file for PR #7565 created/updated

---------



(cherry picked from commit f3dee46)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 1, 2024
…bulk_get response (opensearch-project#7565)

* fix missing fields

Signed-off-by: Hailong Cui <[email protected]>

* Changeset file for PR opensearch-project#7565 created/updated

---------

Signed-off-by: Hailong Cui <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants