[Vis-Builder] Fix Droppable Areas not highlighting while dragging a Field #7527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDrago27
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
virajsanghvi and
sejli
as code owners
LDrago27
added
vis builder
bug
opensearch-changeset-bot bot
added a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Jul 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7527 +/- ##
==========================================
- Coverage 63.82% 63.80% -0.02%
==========================================
Files 3650 3651 +1
Lines 80966 80985 +19
Branches 12894 12901 +7
==========================================
+ Hits 51673 51674 +1
- Misses 26126 26144 +18
Partials 3167 3167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Move to 2.17 for now due to test fail. |
LDrago27
force-pushed
the
visBuilderHighlightBugFix
branch
from
2b4849f to
44be361
Compare
LDrago27
force-pushed
the
visBuilderHighlightBugFix
branch
from
a1904ca to
44be361
Compare
Signed-off-by: Suchit Sahoo <[email protected]>
LDrago27
force-pushed
the
visBuilderHighlightBugFix
branch
from
44be361 to
3c8686c
Compare
ananzh
previously approved these changes
Aug 16, 2024
ananzh
approved these changes
Aug 16, 2024
ashwin-pc
approved these changes
Aug 21, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
…ield (#7527) * [Vis-Builder] Highlight Droppable Areas while dragging a Field Signed-off-by: Suchit Sahoo <[email protected]> * Changeset file for PR #7527 created/updated --------- Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 901ac51) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh
pushed a commit
that referenced
this pull request
Aug 21, 2024
…ield (#7527) (#7780) * [Vis-Builder] Highlight Droppable Areas while dragging a Field * Changeset file for PR #7527 created/updated --------- (cherry picked from commit 901ac51) Signed-off-by: Suchit Sahoo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to enhance the user experience in Vis Builder by highlighting the droppable areas when a user starts dragging a field and fixing the bug which removed this feature.
Issues Resolved
Screenshot
HighilightVisbuilderbugFix.mp4
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration