[Workspace]Fix breadcrumbs not set properly when out a workspace #7432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hailong-am
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27 and
virajsanghvi
as code owners
github-actions
bot
added
seasoned-contributor
Skip-Changelog
Signed-off-by: Hailong Cui <[email protected]>
SuZhou-Joe
approved these changes
Jul 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7432 +/- ##
=======================================
Coverage 64.13% 64.13%
=======================================
Files 3614 3614
Lines 78681 78680 -1
Branches 12432 12432
=======================================
+ Hits 50462 50463 +1
+ Misses 25168 25167 -1
+ Partials 3051 3050 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruanyl
approved these changes
Jul 24, 2024
|
failed test not related this change |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit f872b02) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit f872b02) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Jul 24, 2024
(cherry picked from commit f872b02) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Jul 24, 2024
(cherry picked from commit f872b02) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Aug 1, 2024
…ject#7432) Signed-off-by: Hailong Cui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the breadcrumbs enricher reset when out a workspace, the enricher will set by nav group service if we are in data administration or settings and setup pages
There has 3 cases
Issues Resolved
#7359 bug in #7360
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration