Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Workspace] Copy selected/all saved objects #7429

Merged
merged 1 commit into from
Jul 24, 2024
Merged

[Backport 2.x] [Workspace] Copy selected/all saved objects #7429

merged 1 commit into from
Jul 24, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 9abde5c from #6478.

@github-actions @opensearch-changeset-bot
[Workspace] Copy selected/all saved objects (#6478)
7daf7bb 
* [Worksapce][UI] duplicate selected/all saved objects

Signed-off-by: yubonluo <[email protected]>

* fix test error

Signed-off-by: yubonluo <[email protected]>

* optimize code transfer memory

Signed-off-by: yubonluo <[email protected]>

* revert useless modify

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* add test id

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR #6478 created/updated

* According the last mockup to optimize the code

Signed-off-by: yubonluo <[email protected]>

* Delete useless code

Signed-off-by: yubonluo <[email protected]>

* Optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize code

Signed-off-by: yubonluo <[email protected]>

* delete useless code

Signed-off-by: yubonluo <[email protected]>

* Optimize user experience

Signed-off-by: yubonluo <[email protected]>

* Solve the test snapshot error

Signed-off-by: yubonluo <[email protected]>

* modefy the ui text

Signed-off-by: yubonluo <[email protected]>

* support copy result flyout

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 9abde5c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Jul 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.89189% with 12 lines in your changes missing coverage. Please review.

Project coverage is 67.81%. Comparing base (77f6c70) to head (7daf7bb).

Files Patch % Lines
...ment_section/objects_table/saved_objects_table.tsx 87.03% 4 Missing and 3 partials ⚠️
...ction/objects_table/components/duplicate_modal.tsx 89.28% 1 Missing and 2 partials ⚠️
...jects_table/components/duplicate_result_flyout.tsx 97.43% 0 Missing and 1 partial ⚠️
...agement_section/objects_table/components/table.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #7429      +/-   ##
==========================================
+ Coverage   67.76%   67.81%   +0.04%     
==========================================
  Files        3595     3600       +5     
  Lines       72451    72606     +155     
  Branches    11869    11899      +30     
==========================================
+ Hits        49100    49235     +135     
- Misses      20359    20376      +17     
- Partials     2992     2995       +3
Flag Coverage Δ
Linux_1 32.94% <6.16%> (-0.49%) ⬇️
Linux_2 55.66% <ø> (ø)
Linux_4 34.38% <91.54%> (+0.19%) ⬆️
Windows_1 32.96% <6.16%> (-0.49%) ⬇️
Windows_2 55.61% <ø> (ø)
Windows_3 43.67% <2.14%> (-0.80%) ⬇️
Windows_4 34.38% <91.54%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl
Copy link
Member

ruanyl commented Jul 24, 2024

Confirmed with @yubonluo that the testing failures in ciGroup1 and ciGroup3 are not related

@ruanyl ruanyl merged commit 2bc4669 into 2.x Jul 24, 2024
67 of 71 checks passed
ananzh pushed a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 24, 2024
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @ananzh
[Workspace] Copy selected/all saved objects (opensearch-project#6478) (…
2af3947 
…opensearch-project#7429)

* [Worksapce][UI] duplicate selected/all saved objects



* fix test error



* optimize code transfer memory



* revert useless modify



* optimize the code



* add test id



* Changeset file for PR opensearch-project#6478 created/updated

* According the last mockup to optimize the code



* Delete useless code



* Optimize the code



* optimize code



* delete useless code



* Optimize user experience



* Solve the test snapshot error



* modefy the ui text



* support copy result flyout



* optimize the code



* optimize the code



---------



(cherry picked from commit 9abde5c)

Signed-off-by: yubonluo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@ananzh ananzh mentioned this pull request Jul 24, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ruanyl ruanyl ruanyl approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports failed changeset first-time-contributor v2.16.0 workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruanyl @SuZhou-Joe @kavilla