Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query assist): update reading data source id from dataset #7418

Closed
wants to merge 66 commits into from

Conversation

joshuali925
Copy link
Member

@joshuali925 joshuali925 commented Jul 23, 2024

Description

NOTE: This PR is based on #7368. do not merge it before #7368.

The diff is hard to review because it contains change from another PR. See https://github.com/opensearch-project/OpenSearch-Dashboards/compare/26b16ffe0f098a35f54d8a819698d09550d97bc1%5E..joshuali925:pr/7368 for the change on top

This PR reverts the logic for retrieving data source id from using connection service back to current index pattern, as connection service is removed in #7368

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: update reading data source id from dataset in query assist

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

sejli and others added 30 commits July 22, 2024 22:45
Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
kavilla and others added 25 commits July 23, 2024 00:49
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
…enSearch-Dashboards-1 into lnse/dataset-selector-4-rocky
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 23.99021% with 621 lines in your changes missing coverage. Please review.

Project coverage is 63.76%. Comparing base (c8496f8) to head (1e5fa6c).
Report is 2 commits behind head on main.

Files Patch % Lines
.../public/ui/dataset_navigator/dataset_navigator.tsx 0.55% 179 Missing ⚠️
...taset_navigator/lib/catalog_cache/cache_loader.tsx 8.10% 136 Missing ⚠️
...taset_navigator/lib/catalog_cache/cache_manager.ts 3.93% 122 Missing ⚠️
...blic/ui/dataset_navigator/lib/utils/use_polling.ts 0.00% 57 Missing ⚠️
.../dataset_navigator/lib/hooks/direct_query_hook.tsx 2.94% 33 Missing ⚠️
...ta/public/ui/dataset_navigator/lib/requests/sql.ts 0.00% 18 Missing ⚠️
...ta/public/ui/dataset_navigator/lib/utils/shared.ts 88.23% 14 Missing ⚠️
...navigator/lib/utils/fetch_external_data_sources.ts 15.38% 11 Missing ⚠️
...ic/ui/dataset_navigator/lib/utils/fetch_indices.ts 11.11% 8 Missing ⚠️
.../data_explorer/public/components/sidebar/index.tsx 36.36% 7 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7418      +/-   ##
==========================================
- Coverage   64.06%   63.76%   -0.31%     
==========================================
  Files        3603     3627      +24     
  Lines       78477    79370     +893     
  Branches    12382    12547     +165     
==========================================
+ Hits        50280    50607     +327     
- Misses      25167    25715     +548     
- Partials     3030     3048      +18     
Flag Coverage Δ
Linux_1 30.78% <21.72%> (+0.10%) ⬆️
Linux_2 55.57% <0.00%> (-0.01%) ⬇️
Linux_3 ?
Linux_4 31.67% <23.50%> (-0.10%) ⬇️
Windows_1 30.80% <21.72%> (+0.10%) ⬆️
Windows_2 55.52% <0.00%> (-0.01%) ⬇️
Windows_3 40.36% <22.25%> (-0.30%) ⬇️
Windows_4 31.67% <23.50%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuali925
Copy link
Member Author

#7368 won't go in, closing this for #7464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants