Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][DataSource] No restriction on setting default data source #7396

Merged
merged 2 commits into from
Jul 23, 2024
Merged

[Bug][DataSource] No restriction on setting default data source #7396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e3b3e3
No restriction on setting default data source
yubonluo Jul 23, 2024
8b1a82e
Changeset file for PR #7396 created/updated
opensearch-changeset-bot[bot] Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/7396.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- [DataSource] No restriction on setting default data source ([#7396](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7396))
3 changes: 0 additions & 3 deletions ...ta_source_management/public/components/edit_data_source/components/header/header.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,5 @@ describe('Datasource Management: Edit Datasource Header', () => {
expect(component.find(headerTitleIdentifier).last().text()).toBe(dataSourceName);
expect(component.find(deleteIconIdentifier).exists()).toBe(false);
});
test('should not show default icon', () => {
expect(component.find(setDefaultButtonIdentifier).exists()).toBe(false);
});
});
});
4 changes: 1 addition & 3 deletions ...ns/data_source_management/public/components/edit_data_source/components/header/header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,7 @@ export const Header = ({
<EuiFlexItem grow={false}>
<EuiFlexGroup alignItems="baseline" gutterSize="m" responsive={false}>
{/* Test default button */}
{canManageDataSource ? (
<EuiFlexItem grow={false}>{renderDefaultIcon()}</EuiFlexItem>
) : null}
<EuiFlexItem grow={false}>{renderDefaultIcon()}</EuiFlexItem>
{/* Test connection button */}
<EuiFlexItem grow={false}>{renderTestConnectionButton()}</EuiFlexItem>
{/* Delete icon button */}
Expand Down
Loading