[HomePage] Add home page static list card #7351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tygao <[email protected]>
raintygao
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27 and
virajsanghvi
as code owners
SuZhou-Joe
reviewed
Jul 22, 2024
| import { EuiCard, EuiLink, EuiListGroup } from '@elastic/eui'; | ||
|
|
||
| export const LEARN_OPENSEARCH_CONFIG = { | ||
| title: 'Learn Opensearch', |
There was a problem hiding this comment.
Shall we at least wrap it with i18n?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7351 +/- ##
==========================================
- Coverage 67.70% 67.70% -0.01%
==========================================
Files 3519 3520 +1
Lines 69685 69700 +15
Branches 11374 11376 +2
==========================================
+ Hits 47183 47189 +6
- Misses 19708 19716 +8
- Partials 2794 2795 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruanyl
reviewed
Jul 22, 2024
| ) : null | ||
| } | ||
| > | ||
| <EuiListGroup listItems={config.list} color="text" size="s" /> |
There was a problem hiding this comment.
If description is needed, I think we should use DescriptionList component https://oui.opensearch.org/1.8/#/display/description-list
Signed-off-by: tygao <[email protected]>
ruanyl
approved these changes
Jul 22, 2024
|
Nit: Shall we move the View all to the bottom of the card? |
SuZhou-Joe
approved these changes
Jul 22, 2024
According to latest design, it shows that this link is not docked to bottom. So i didn't implement this for now. But im glad to use some style like flex to make it docked to bottom in next update if needed. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
* feat: add home static list card Signed-off-by: tygao <[email protected]> * Changeset file for PR #7351 created/updated * update link property Signed-off-by: tygao <[email protected]> * add i18n and description Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit e64de15) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Have added a comment to confirm with designers. |
ruanyl
pushed a commit
that referenced
this pull request
Jul 22, 2024
* feat: add home static list card * Changeset file for PR #7351 created/updated * update link property * add i18n and description --------- (cherry picked from commit e64de15) Signed-off-by: tygao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
* feat: add home static list card * Changeset file for PR #7351 created/updated * update link property * add i18n and description --------- (cherry picked from commit e64de15) Signed-off-by: tygao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 6685bce) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jul 23, 2024
* feat: add home static list card * Changeset file for PR #7351 created/updated * update link property * add i18n and description --------- (cherry picked from commit e64de15) (cherry picked from commit 6685bce) Signed-off-by: tygao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add home page static list card
Screenshot
Testing the changes
Enable new homepage and go to homepage.
Changelog
Check List
yarn test:jestyarn test:jest_integration