Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Navigation-next]Register workspace list card into home page #7350

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b32eade from #7247.

* workspace list card on home

Signed-off-by: Hailong Cui <[email protected]>

* fix merge conflicts

Signed-off-by: Hailong Cui <[email protected]>

* add home as requiredBundles

Signed-off-by: Hailong Cui <[email protected]>

* Changeset file for PR #7247 created/updated

* fix failed UT

Signed-off-by: Hailong Cui <[email protected]>

* address review comments

Signed-off-by: Hailong Cui <[email protected]>

* update to funtional component

Signed-off-by: Hailong Cui <[email protected]>

* udpate content provider id

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit b32eade)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 58.53659% with 17 lines in your changes missing coverage. Please review.

Project coverage is 68.13%. Comparing base (c30287a) to head (c022a87).

Files Patch % Lines
...ic/components/service_card/workspace_list_card.tsx 62.85% 9 Missing and 4 partials ⚠️
src/plugins/workspace/public/plugin.ts 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #7350      +/-   ##
==========================================
- Coverage   68.14%   68.13%   -0.01%     
==========================================
  Files        3470     3471       +1     
  Lines       68712    68753      +41     
  Branches    11197    11205       +8     
==========================================
+ Hits        46821    46843      +22     
- Misses      19154    19167      +13     
- Partials     2737     2743       +6     
Flag Coverage Δ
Linux_1 33.27% <58.53%> (+0.02%) ⬆️
Linux_2 55.58% <ø> (ø)
Linux_3 43.14% <ø> (-0.02%) ⬇️
Linux_4 34.83% <ø> (ø)
Windows_1 33.29% <58.53%> (+0.02%) ⬆️
Windows_2 55.53% <ø> (ø)
Windows_3 43.16% <ø> (ø)
Windows_4 34.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 8a6da4c into 2.x Jul 22, 2024
66 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset seasoned-contributor v2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants