Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Register four get started cards in home page #7333

Merged
merged 6 commits into from
Jul 21, 2024

Conversation

yubonluo
Copy link
Contributor

@yubonluo yubonluo commented Jul 20, 2024

Description

Register four get started cards in home page.

Issues Resolved

#7332

Screenshot

image
image
image

Testing the changes

  1. Clone the latest osd code and run yarn osd bootstrap
  2. Modify config/opensearch_dashboards.yml
workspace.enabled: true 
uiSettings:
  overrides:
    "home:useNewHomePage": true
  1. Run yarn start --no-base-path
  2. Click workspace picker

Changelog

  • feat: [Workspace] Register four get started cards in home page

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 86.88525% with 8 lines in your changes missing coverage. Please review.

Project coverage is 67.71%. Comparing base (7f9bdd7) to head (5a2a1d8).
Report is 2 commits behind head on main.

Files Patch % Lines
src/plugins/workspace/public/plugin.ts 50.00% 4 Missing ⚠️
...nt_management/public/components/section_render.tsx 50.00% 1 Missing and 2 partials ⚠️
...components/home_get_start_card/use_case_footer.tsx 97.43% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7333      +/-   ##
==========================================
+ Coverage   67.69%   67.71%   +0.01%     
==========================================
  Files        3517     3518       +1     
  Lines       69578    69638      +60     
  Branches    11354    11365      +11     
==========================================
+ Hits        47102    47155      +53     
- Misses      19691    19695       +4     
- Partials     2785     2788       +3     
Flag Coverage Δ
Linux_1 33.16% <80.32%> (-0.06%) ⬇️
Linux_2 55.46% <ø> (ø)
Linux_3 43.32% <57.14%> (+<0.01%) ⬆️
Linux_4 34.69% <0.00%> (-0.01%) ⬇️
Windows_1 33.18% <80.32%> (-0.06%) ⬇️
Windows_2 55.41% <ø> (ø)
Windows_3 43.33% <57.14%> (+<0.01%) ⬆️
Windows_4 34.69% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: yubonluo <[email protected]>
ruanyl
ruanyl previously approved these changes Jul 20, 2024
Copy link
Member

@ruanyl ruanyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for address the issue so quickly, it looks good to me now :)

src/plugins/workspace/public/plugin.ts Outdated Show resolved Hide resolved
SuZhou-Joe
SuZhou-Joe previously approved these changes Jul 20, 2024
@yubonluo yubonluo force-pushed the 2.16-get-start-card branch from 645842d to 29c80dd Compare July 21, 2024 02:07
SuZhou-Joe
SuZhou-Joe previously approved these changes Jul 21, 2024
Signed-off-by: yubonluo <[email protected]>
@yubonluo yubonluo force-pushed the 2.16-get-start-card branch from e62a2ce to 5a2a1d8 Compare July 21, 2024 03:08
@SuZhou-Joe SuZhou-Joe merged commit 08c2a00 into opensearch-project:main Jul 21, 2024
71 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 21, 2024
* support get start card in home page

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR #7333 created/updated

* fix unit test errors

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 08c2a00)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Jul 21, 2024
* support get start card in home page



* Changeset file for PR #7333 created/updated

* fix unit test errors



* optimize the code



---------



(cherry picked from commit 08c2a00)

Signed-off-by: yubonluo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants