[navigation-next] fix: redirect to standard index pattern applications while nav group is enabled #7305

SuZhou-Joe · 2024-07-18T13:53:14Z

Description

When nav group is enabled and users want to visit Dashboards page if no index pattern is configured in their OSD, OSD will direct user to the index pattern page, which is a sub app under management.

This PR is mainly to solve this problem by redirecting users to the right application.

Address the issue that in-app navigation is not hide when nav group is enabled.
Address the issue that the app will still navigate to legacy index pattern management oage.
Address the scss code concern from @AMoo-Miki

Issues Resolved

Screenshot

Before the fix

20240718214149613.mp4

After the fix

20240718214309128.mp4

Testing the changes

Changelog

feat: [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

codecov · 2024-07-18T14:12:29Z

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.73%. Comparing base (08c2a00) to head (dfbda01).

Files	Patch %	Lines
...chrome/ui/header/collapsible_nav_group_enabled.tsx	81.81%	1 Missing and 1 partial ⚠️
.../plugins/index_pattern_management/public/plugin.ts	87.50%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@                     Coverage Diff                     @@
##           feature/navigation-next    #7305      +/-   ##
===========================================================
+ Coverage                    67.71%   67.73%   +0.02%     
===========================================================
  Files                         3518     3518              
  Lines                        69638    69643       +5     
  Branches                     11365    11365              
===========================================================
+ Hits                         47153    47175      +22     
+ Misses                       19696    19681      -15     
+ Partials                      2789     2787       -2

Flag	Coverage Δ
Linux_1	`33.16% <8.33%> (+<0.01%)`	⬆️
Linux_2	`55.46% <81.81%> (-0.01%)`	⬇️
Linux_3	`43.32% <9.52%> (+<0.01%)`	⬆️
Linux_4	`34.70% <42.85%> (+0.01%)`	⬆️
Windows_1	`33.21% <8.33%> (+0.02%)`	⬆️
Windows_2	`55.41% <81.81%> (-0.01%)`	⬇️
Windows_3	`43.33% <9.52%> (-0.01%)`	⬇️
Windows_4	`34.71% <42.85%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

virajsanghvi

Can you update after video (think its the same as before)?

src/core/public/chrome/nav_group/nav_group_service.ts

SuZhou-Joe · 2024-07-20T03:02:38Z

Can you update after video (think its the same as before)?

Thanks for catching this, updated with correct video.

ruanyl · 2024-07-20T05:42:46Z

src/core/public/chrome/ui/header/collapsible_nav_group_enabled.scss

-    padding: $ouiSize / 4 $ouiSize;
-    border-radius: $ouiSize;
+    padding: calc($euiSize / 4) $euiSize;
+    border-radius: $euiSize;


Are these changes expected? Seems unrelated

It is expected, as @AMoo-Miki suggested me to do so.

Signed-off-by: SuZhou-Joe <[email protected]>

…s while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #7305 created/updated * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: update with comment Signed-off-by: SuZhou-Joe <[email protected]> * feat: update order and remove reset logic Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: update snapshot Signed-off-by: SuZhou-Joe <[email protected]> * feat: some category change Signed-off-by: SuZhou-Joe <[email protected]> * feat: update category Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 2c708e3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…s while nav group is enabled (#7346) * [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #7305 created/updated * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: update with comment Signed-off-by: SuZhou-Joe <[email protected]> * feat: update order and remove reset logic Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: update snapshot Signed-off-by: SuZhou-Joe <[email protected]> * feat: some category change Signed-off-by: SuZhou-Joe <[email protected]> * feat: update category Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 2c708e3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: change the order Signed-off-by: SuZhou-Joe <[email protected]> * feat: hide left navigation when workspace enabled Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <[email protected]>

…s while nav group is enabled (#7346) * [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #7305 created/updated * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: update with comment Signed-off-by: SuZhou-Joe <[email protected]> * feat: update order and remove reset logic Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: update snapshot Signed-off-by: SuZhou-Joe <[email protected]> * feat: some category change Signed-off-by: SuZhou-Joe <[email protected]> * feat: update category Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 2c708e3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: change the order Signed-off-by: SuZhou-Joe <[email protected]> * feat: hide left navigation when workspace enabled Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <[email protected]> (cherry picked from commit d30677d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…s while nav group is enabled (#7346) (#7352) * [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management * Changeset file for PR #7305 created/updated * feat: update * feat: update with comment * feat: update order and remove reset logic * feat: update * feat: update * feat: update snapshot * feat: some category change * feat: update category --------- (cherry picked from commit 2c708e3) * feat: change the order * feat: hide left navigation when workspace enabled --------- (cherry picked from commit d30677d) Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <[email protected]>

* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #7305 created/updated * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: update with comment Signed-off-by: SuZhou-Joe <[email protected]> * feat: update order and remove reset logic Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: update snapshot Signed-off-by: SuZhou-Joe <[email protected]> * feat: some category change Signed-off-by: SuZhou-Joe <[email protected]> * feat: update category Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * fix: bugs found in integration test Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #7356 created/updated * feat: show workspace detail in all use case Signed-off-by: SuZhou-Joe <[email protected]> * fix: unit test error Signed-off-by: SuZhou-Joe <[email protected]> * feat: revert back detect category Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #7305 created/updated * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: update with comment Signed-off-by: SuZhou-Joe <[email protected]> * feat: update order and remove reset logic Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: update snapshot Signed-off-by: SuZhou-Joe <[email protected]> * feat: some category change Signed-off-by: SuZhou-Joe <[email protected]> * feat: update category Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * fix: bugs found in integration test Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #7356 created/updated * feat: show workspace detail in all use case Signed-off-by: SuZhou-Joe <[email protected]> * fix: unit test error Signed-off-by: SuZhou-Joe <[email protected]> * feat: revert back detect category Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 8b46c44) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management * Changeset file for PR #7305 created/updated * feat: update * feat: update with comment * feat: update order and remove reset logic * feat: update * feat: update * feat: update snapshot * feat: some category change * feat: update category --------- * fix: bugs found in integration test * Changeset file for PR #7356 created/updated * feat: show workspace detail in all use case * fix: unit test error * feat: revert back detect category --------- (cherry picked from commit 8b46c44) Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…roject#7377) * [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (opensearch-project#7305) * feat: fix the incorrect jumping logic for Index pattern management * Changeset file for PR opensearch-project#7305 created/updated * feat: update * feat: update with comment * feat: update order and remove reset logic * feat: update * feat: update * feat: update snapshot * feat: some category change * feat: update category --------- * fix: bugs found in integration test * Changeset file for PR opensearch-project#7356 created/updated * feat: show workspace detail in all use case * fix: unit test error * feat: revert back detect category --------- (cherry picked from commit 8b46c44) Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 6551af7)

* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management * Changeset file for PR #7305 created/updated * feat: update * feat: update with comment * feat: update order and remove reset logic * feat: update * feat: update * feat: update snapshot * feat: some category change * feat: update category --------- * fix: bugs found in integration test * Changeset file for PR #7356 created/updated * feat: show workspace detail in all use case * fix: unit test error * feat: revert back detect category --------- (cherry picked from commit 8b46c44) Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 6551af7) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>

* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management * Changeset file for PR #7305 created/updated * feat: update * feat: update with comment * feat: update order and remove reset logic * feat: update * feat: update * feat: update snapshot * feat: some category change * feat: update category --------- * fix: bugs found in integration test * Changeset file for PR #7356 created/updated * feat: show workspace detail in all use case * fix: unit test error * feat: revert back detect category --------- (cherry picked from commit 8b46c44) Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 6551af7) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> (cherry picked from commit 7adc980) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management * Changeset file for PR #7305 created/updated * feat: update * feat: update with comment * feat: update order and remove reset logic * feat: update * feat: update * feat: update snapshot * feat: some category change * feat: update category --------- * fix: bugs found in integration test * Changeset file for PR #7356 created/updated * feat: show workspace detail in all use case * fix: unit test error * feat: revert back detect category --------- (cherry picked from commit 8b46c44) (cherry picked from commit 6551af7) (cherry picked from commit 7adc980) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>

* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management * Changeset file for PR #7305 created/updated * feat: update * feat: update with comment * feat: update order and remove reset logic * feat: update * feat: update * feat: update snapshot * feat: some category change * feat: update category --------- * fix: bugs found in integration test * Changeset file for PR #7356 created/updated * feat: show workspace detail in all use case * fix: unit test error * feat: revert back detect category --------- (cherry picked from commit 8b46c44) (cherry picked from commit 6551af7) (cherry picked from commit 7adc980) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> (cherry picked from commit 0429e8a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* [navigation-next] fix: redirect to standard index pattern applications while nav group is enabled (#7305) * feat: fix the incorrect jumping logic for Index pattern management * Changeset file for PR #7305 created/updated * feat: update * feat: update with comment * feat: update order and remove reset logic * feat: update * feat: update * feat: update snapshot * feat: some category change * feat: update category --------- * fix: bugs found in integration test * Changeset file for PR #7356 created/updated * feat: show workspace detail in all use case * fix: unit test error * feat: revert back detect category --------- (cherry picked from commit 8b46c44) (cherry picked from commit 6551af7) (cherry picked from commit 7adc980) (cherry picked from commit 0429e8a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>

SuZhou-Joe requested review from ananzh, kavilla, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, curq, bandinib-amzn, ruanyl, BionIT, xinruiba, zhyuanqi, mengweieric, LDrago27 and virajsanghvi as code owners July 18, 2024 13:53

github-actions bot added all-star-contributor failed changeset labels Jul 18, 2024

opensearch-project deleted a comment from github-actions bot Jul 18, 2024

opensearch-changeset-bot bot added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Jul 18, 2024

Changeset file for PR opensearch-project#7305 created/updated

b9b021e

github-actions bot removed the failed changeset label Jul 18, 2024

virajsanghvi reviewed Jul 19, 2024

View reviewed changes

src/core/public/chrome/nav_group/nav_group_service.ts Outdated Show resolved Hide resolved

ruanyl reviewed Jul 20, 2024

View reviewed changes

SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Jul 21, 2024

Changeset file for PR opensearch-project#7305 created/updated

d38756e

SuZhou-Joe force-pushed the fix/redirect-index-pattern branch from 7f85fe9 to 3670a30 Compare July 21, 2024 04:25

SuZhou-Joe and others added 10 commits July 21, 2024 14:17

feat: fix the incorrect jumping logic for Index pattern management

fe7e6ad

Signed-off-by: SuZhou-Joe <[email protected]>

Changeset file for PR opensearch-project#7305 created/updated

e6b8c30

feat: update

af063cd

Signed-off-by: SuZhou-Joe <[email protected]>

feat: update with comment

72b3519

Signed-off-by: SuZhou-Joe <[email protected]>

feat: update order and remove reset logic

8e07712

Signed-off-by: SuZhou-Joe <[email protected]>

feat: update

a04e203

Signed-off-by: SuZhou-Joe <[email protected]>

feat: update

88dc602

Signed-off-by: SuZhou-Joe <[email protected]>

feat: update snapshot

b7a0ad8

Signed-off-by: SuZhou-Joe <[email protected]>

feat: some category change

62d7a16

Signed-off-by: SuZhou-Joe <[email protected]>

feat: update category

dfbda01

Signed-off-by: SuZhou-Joe <[email protected]>

SuZhou-Joe force-pushed the fix/redirect-index-pattern branch from eb7afb2 to dfbda01 Compare July 21, 2024 06:17

SuZhou-Joe changed the base branch from main to feature/navigation-next July 21, 2024 07:07

SuZhou-Joe added the backport main label Jul 21, 2024

SuZhou-Joe merged commit 2c708e3 into opensearch-project:feature/navigation-next Jul 21, 2024
70 checks passed

opensearch-trigger-bot bot mentioned this pull request Jul 21, 2024

[navigation-next] fix: redirect to standard index pattern applications while nav group is enabled #7346

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[navigation-next] fix: redirect to standard index pattern applications while nav group is enabled #7305

[navigation-next] fix: redirect to standard index pattern applications while nav group is enabled #7305

SuZhou-Joe commented Jul 18, 2024 •

edited

Loading

codecov bot commented Jul 18, 2024 •

edited

Loading

virajsanghvi left a comment

SuZhou-Joe commented Jul 20, 2024

ruanyl Jul 20, 2024

SuZhou-Joe Jul 20, 2024 •

edited

Loading

[navigation-next] fix: redirect to standard index pattern applications while nav group is enabled #7305

[navigation-next] fix: redirect to standard index pattern applications while nav group is enabled #7305

Conversation

SuZhou-Joe commented Jul 18, 2024 • edited Loading

Description

Issues Resolved

Screenshot

Before the fix

After the fix

Testing the changes

Changelog

Check List

codecov bot commented Jul 18, 2024 • edited Loading

Codecov Report

virajsanghvi left a comment

Choose a reason for hiding this comment

SuZhou-Joe commented Jul 20, 2024

ruanyl Jul 20, 2024

Choose a reason for hiding this comment

SuZhou-Joe Jul 20, 2024 • edited Loading

Choose a reason for hiding this comment

SuZhou-Joe commented Jul 18, 2024 •

edited

Loading

codecov bot commented Jul 18, 2024 •

edited

Loading

SuZhou-Joe Jul 20, 2024 •

edited

Loading