-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Look&Feel] Apply missing pattern guidance to Dashboards experience #7277
Conversation
Signed-off-by: Zhongnan Su <[email protected]>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7277 +/- ##
==========================================
- Coverage 67.32% 67.31% -0.02%
==========================================
Files 3500 3500
Lines 69219 69219
Branches 11275 11275
==========================================
- Hits 46605 46598 -7
- Misses 19890 19899 +9
+ Partials 2724 2722 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good but can you double check failing checks?
sure, still I don't think it's related to the code change. Re-running |
Signed-off-by: Zhongnan Su <[email protected]> (cherry picked from commit 6d6ffaa) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 6d6ffaa) Signed-off-by: Zhongnan Su <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Validate if all pattern guidances are applied in Dashboards, and add what's missing. (except small buttons and inputs, which will be worked on separately)
Below are the items covered by with this PR
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration