Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Look&Feel] Apply missing pattern guidance to Dashboards experience #7277

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented Jul 17, 2024

Description

Validate if all pattern guidances are applied in Dashboards, and add what's missing. (except small buttons and inputs, which will be worked on separately)

Below are the items covered by with this PR

image

Issues Resolved

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@zhongnansu zhongnansu added look & feel Look and Feel Improvements v2.16.0 labels Jul 17, 2024
@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.31%. Comparing base (f1be0d6) to head (9ead810).
Report is 321 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7277      +/-   ##
==========================================
- Coverage   67.32%   67.31%   -0.02%     
==========================================
  Files        3500     3500              
  Lines       69219    69219              
  Branches    11275    11275              
==========================================
- Hits        46605    46598       -7     
- Misses      19890    19899       +9     
+ Partials     2724     2722       -2     
Flag Coverage Δ
Linux_1 33.24% <ø> (ø)
Linux_2 55.30% <ø> (ø)
Linux_3 45.26% <ø> (-0.02%) ⬇️
Linux_4 34.70% <ø> (?)
Windows_1 33.26% <ø> (-0.03%) ⬇️
Windows_2 55.25% <ø> (ø)
Windows_3 45.27% <ø> (ø)
Windows_4 34.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but can you double check failing checks?

@zhongnansu
Copy link
Member Author

Changes look good but can you double check failing checks?

sure, still I don't think it's related to the code change. Re-running

@zhongnansu zhongnansu merged commit 6d6ffaa into opensearch-project:main Jul 17, 2024
74 of 77 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 17, 2024
Signed-off-by: Zhongnan Su <[email protected]>
(cherry picked from commit 6d6ffaa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhongnansu pushed a commit that referenced this pull request Jul 18, 2024
(cherry picked from commit 6d6ffaa)

Signed-off-by: Zhongnan Su <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x distinguished-contributor in-next look & feel Look and Feel Improvements Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants