Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation-next] Add new category #7275

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Jul 17, 2024

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

  • feat: [navigation-next] Add new category

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.71%. Comparing base (f1be0d6) to head (4ef1e42).
Report is 2 commits behind head on feature/navigation-next.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           feature/navigation-next    #7275      +/-   ##
===========================================================
- Coverage                    67.32%   62.71%   -4.62%     
===========================================================
  Files                         3500     3055     -445     
  Lines                        69219    60988    -8231     
  Branches                     11275    10045    -1230     
===========================================================
- Hits                         46605    38248    -8357     
- Misses                       19890    20548     +658     
+ Partials                      2724     2192     -532     
Flag Coverage Δ
Linux_1 ?
Linux_2 55.10% <ø> (-0.20%) ⬇️
Linux_3 45.10% <ø> (-0.17%) ⬇️
Windows_1 33.18% <ø> (-0.11%) ⬇️
Windows_2 55.06% <ø> (-0.20%) ⬇️
Windows_3 ?
Windows_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 84537b5 into opensearch-project:feature/navigation-next Jul 17, 2024
65 of 68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 17, 2024
* feat: add new categories

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR #7273 created/updated

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR #7275 created/updated

* feat: remove useless changelog

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless changelog

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 84537b5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Jul 17, 2024
* feat: add new categories



* Changeset file for PR #7273 created/updated

* feat: update



* Changeset file for PR #7275 created/updated

* feat: remove useless changelog



* feat: remove useless changelog



---------



(cherry picked from commit 84537b5)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 17, 2024
* feat: add new categories

* Changeset file for PR #7273 created/updated

* feat: update

* Changeset file for PR #7275 created/updated

* feat: remove useless changelog

* feat: remove useless changelog

---------

(cherry picked from commit 84537b5)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit d2e7b9d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Jul 17, 2024
* feat: add new categories

* Changeset file for PR #7273 created/updated

* feat: update

* Changeset file for PR #7275 created/updated

* feat: remove useless changelog

* feat: remove useless changelog

---------

(cherry picked from commit 84537b5)





(cherry picked from commit d2e7b9d)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant