Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Discover not respecting searchOnPageLoad Advanced Setting #7252

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

LDrago27
Copy link
Collaborator

@LDrago27 LDrago27 commented Jul 16, 2024

Description

When we set the searchOnPageLoad Advanced Setting as false , Upon navigating to Discover home page, we can see the page being stuck in a loading state. Refer the image below for reference.

image

Issues Resolved

Screenshot

Testing the changes

  • Set the searchOnPageLoad Advanced Setting to False
  • Navigate to Discover
  • You should See a Page which provides user a option to refresh manually
    Adding a sample image for reference
    image

Changelog

  • fix: Discover page status stuck in loading State

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.62%. Comparing base (b422791) to head (728c1f6).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7252      +/-   ##
==========================================
+ Coverage   67.56%   67.62%   +0.06%     
==========================================
  Files        3469     3471       +2     
  Lines       68479    68613     +134     
  Branches    11130    11165      +35     
==========================================
+ Hits        46266    46399     +133     
+ Misses      19511    19510       -1     
- Partials     2702     2704       +2     
Flag Coverage Δ
Linux_1 33.26% <ø> (+0.13%) ⬆️
Linux_2 55.30% <ø> (+0.03%) ⬆️
Linux_3 45.26% <ø> (-0.05%) ⬇️
Linux_4 34.69% <ø> (-0.03%) ⬇️
Windows_1 33.28% <ø> (+0.13%) ⬆️
Windows_2 55.25% <ø> (+0.03%) ⬆️
Windows_3 45.27% <ø> (-0.05%) ⬇️
Windows_4 34.69% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -22,9 +22,6 @@ export default function DiscoverContext({ children }: React.PropsWithChildren<Vi
...deServices,
...services,
});
searchParams.data$.next({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this new bug?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. This was introduced after 2.15.

Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested the changes locally

Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for correcting this.
Local tests look good.

@ananzh ananzh added v2.16.0 backport 2.x bug Something isn't working labels Jul 16, 2024
@ananzh ananzh merged commit 60ecd36 into opensearch-project:main Jul 16, 2024
73 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 16, 2024
* Fixed Discover Canvas Status stuck in Loading state

Signed-off-by: Suchit Sahoo <[email protected]>

* Changeset file for PR #7252 created/updated

---------

Signed-off-by: Suchit Sahoo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 60ecd36)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@LDrago27 LDrago27 deleted the bugFIXX101 branch July 16, 2024 17:20
LDrago27 pushed a commit that referenced this pull request Jul 16, 2024
…#7262)

* Fixed Discover Canvas Status stuck in Loading state



* Changeset file for PR #7252 created/updated

---------



(cherry picked from commit 60ecd36)

Signed-off-by: Suchit Sahoo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants