New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[navigation-next] Add new left navigation #7230

Merged

SuZhou-Joe merged 28 commits into opensearch-project:main from SuZhou-Joe:feature/add-register-left-interface

Jul 18, 2024

Member

SuZhou-Joe commented Jul 12, 2024 •

edited

Loading

Description

Register apps within core to navGroup.
Enable new left navigation.

Issues Resolved

closes #7148
closes #7094

Screenshot

data source enabled / new navigation enabled

20240717154041829.mp4

data source enabled / new navigation disabled

20240717183614054.mp4

data source disabled / new navigation enabled

20240717155424312.mp4

data source disabled / new navigation disabled

20240717155203221.mp4

Testing the changes

Go to advanced settings to enable new home page config.
Navigate around by using the new left navigation.

Changelog

feat: [navigation-next] Add new left navigation

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

SuZhou-Joe added 11 commits

July 3, 2024 17:04


          [navigation-next] Add CollapsibleNavGroupEnabled component into chrom…

82307c5

…e_service.(opensearch-project#7093)

Signed-off-by: SuZhou-Joe <[email protected]>


          feat: enable parent nav link id

4089a63

Signed-off-by: SuZhou-Joe <[email protected]>


          feat: modify left navigation

1e13a69

Signed-off-by: SuZhou-Joe <[email protected]>


          feat: modify style

899240b

Signed-off-by: SuZhou-Joe <[email protected]>


          feat: enable left bottom

b9c9a77

Signed-off-by: SuZhou-Joe <[email protected]>


          temp: merge

175e880

Signed-off-by: SuZhou-Joe <[email protected]>


          feat: save

0106c19

Signed-off-by: SuZhou-Joe <[email protected]>


          feat: merge

09245b6

Signed-off-by: SuZhou-Joe <[email protected]>


          temp change

f300020

Signed-off-by: SuZhou-Joe <[email protected]>


          temp change

ff9a257

Signed-off-by: SuZhou-Joe <[email protected]>


          temp change

186895c

Signed-off-by: SuZhou-Joe <[email protected]>

SuZhou-Joe requested review from ananzh, kavilla, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, curq, bandinib-amzn, ruanyl, BionIT, xinruiba, zhyuanqi, mengweieric and LDrago27 as code owners

July 12, 2024 09:17

opensearch-project deleted a comment from github-actions bot

opensearch-project deleted a comment from github-actions bot

opensearch-project deleted a comment from github-actions bot


          Changeset file for PR opensearch-project#7230 created/updated

3fc83eb

github-actions bot removed the failed changeset label

opensearch-project deleted a comment from github-actions bot

opensearch-project deleted a comment from github-actions bot

opensearch-project deleted a comment from github-actions bot

opensearch-project deleted a comment from github-actions bot


          feat: update

45d1158

Signed-off-by: SuZhou-Joe <[email protected]>

opensearch-project deleted a comment from github-actions bot

opensearch-project deleted a comment from github-actions bot

opensearch-project deleted a comment from github-actions bot


          feat: update

e63e013

Signed-off-by: SuZhou-Joe <[email protected]>

Member Author

SuZhou-Joe commented Jul 17, 2024

Build and Verify on Linux (ciGroup4) failed because of #7057

SuZhou-Joe added the backport 2.x label

ruanyl approved these changes

View reviewed changes

Member

ruanyl left a comment

Amazing changes, code looks good to me, since we already discussed the design quite a lot, I'm approving now!

src/core/public/chrome/ui/header/collapsible_nav_group_enabled.tsx

+                    return 50;
+                  }
+                  return 270;

Member

ruanyl Jul 18, 2024

Nit: avoid magic number

BionIT reviewed

View reviewed changes

src/core/public/chrome/nav_controls/nav_controls_service.ts Show resolved Hide resolved

src/core/public/chrome/nav_controls/nav_controls_service.ts Show resolved Hide resolved

src/core/public/chrome/ui/header/collapsible_nav_group_enabled.tsx

+                navLinks: ChromeNavLink[];
+                suffix?: React.ReactElement;
+                style?: React.CSSProperties;
+                appId?: string;

Collaborator

BionIT Jul 18, 2024

should optional props be at the end?

src/core/public/chrome/ui/header/collapsible_nav_group_enabled.tsx Show resolved Hide resolved

src/core/public/chrome/ui/header/collapsible_nav_group_enabled.tsx

+                  if (navLink.itemType === LinkItemType.CATEGORY) {
+                    return {
+                      id: navLink.category?.id ?? '',
+                      name: <div className="nav-link-item">{navLink.category?.label ?? ''}</div>,

Collaborator

BionIT Jul 18, 2024

can category be empty label and id?

src/core/public/chrome/ui/header/collapsible_nav_group_enabled.tsx Show resolved Hide resolved

src/core/public/chrome/ui/header/collapsible_nav_group_enabled.tsx

+                const width = useMemo(() => {
+                  if (!isNavOpen) {
+                    return 50;

Collaborator

BionIT Jul 18, 2024

instead of using magic number, can we give it a name, is it percentage or other unit?

Member Author

SuZhou-Joe Jul 18, 2024

Sure, will optimize this part.

src/plugins/management_overview/public/plugin.ts Show resolved Hide resolved

src/plugins/management/public/components/settings_icon.tsx

+              import { Observable } from 'rxjs';
+              import { DEFAULT_NAV_GROUPS, NavGroupItemInMap } from '../../../../core/public';
+              export function SettingsIcon({ core }: { core: CoreStart }) {

Collaborator

BionIT Jul 18, 2024

is this component covered by test?

src/plugins/index_pattern_management/public/plugin.ts Show resolved Hide resolved

BionIT approved these changes

View reviewed changes

SuZhou-Joe merged commit 38ae65b into opensearch-project:main

69 of 70 checks passed

Contributor

opensearch-trigger-bot bot commented Jul 18, 2024

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7230-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 38ae65b22c7f9d5bc7f18669489574d90a4ee9fe
# Push it to GitHub
git push --set-upstream origin backport/backport-7230-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7230-to-2.x.

opensearch-trigger-bot bot added the failed backport label

SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request


          [navigation-next] Add new left navigation (opensearch-project#7230)

5eedfb4

* [navigation-next] Add CollapsibleNavGroupEnabled component into chrome_service.(opensearch-project#7093)

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: enable parent nav link id

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: modify left navigation

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: modify style

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: enable left bottom

Signed-off-by: SuZhou-Joe <[email protected]>

* temp: merge

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: save

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: merge

Signed-off-by: SuZhou-Joe <[email protected]>

* temp change

Signed-off-by: SuZhou-Joe <[email protected]>

* temp change

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: overview page can not be load

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless change

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test error

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: new application

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update category based on latest design

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: do not emphasize see all link

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR opensearch-project#7230 created/updated

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

SuZhou-Joe mentioned this pull request

[Backport 2.x][navigation-next] Add new left navigation (#7230) #7300

Merged

7 tasks

SuZhou-Joe added a commit that referenced this pull request


          [navigation-next] Add new left navigation (#7230) (#7300)

b28aa98

* [navigation-next] Add CollapsibleNavGroupEnabled component into chrome_service.(#7093)



* feat: enable parent nav link id



* feat: modify left navigation



* feat: modify style



* feat: enable left bottom



* temp: merge



* feat: save



* feat: merge



* temp change



* temp change



* fix: overview page can not be load



* feat: remove useless change



* feat: add unit test



* feat: update snapshot



* fix: unit test error



* fix: new application



* feat: add unit test



* feat: update category based on latest design



* feat: update



* feat: update snapshot



* feat: do not emphasize see all link



* Changeset file for PR #7230 created/updated

* feat: update



* feat: update



---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

opensearch-trigger-bot bot pushed a commit that referenced this pull request


          [navigation-next] Add new left navigation (#7230) (#7300)

3bde1dc

* [navigation-next] Add CollapsibleNavGroupEnabled component into chrome_service.(#7093)

* feat: enable parent nav link id

* feat: modify left navigation

* feat: modify style

* feat: enable left bottom

* temp: merge

* feat: save

* feat: merge

* temp change

* temp change

* fix: overview page can not be load

* feat: remove useless change

* feat: add unit test

* feat: update snapshot

* fix: unit test error

* fix: new application

* feat: add unit test

* feat: update category based on latest design

* feat: update

* feat: update snapshot

* feat: do not emphasize see all link

* Changeset file for PR #7230 created/updated

* feat: update

* feat: update

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit b28aa98)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

SuZhou-Joe mentioned this pull request

[Backport 2.x][navigation-next] Add new left navigation (#7230) #7301

Merged

SuZhou-Joe pushed a commit that referenced this pull request


          [navigation-next] Add new left navigation (#7230) (#7300) (#7301)

ac22fd2

* [navigation-next] Add CollapsibleNavGroupEnabled component into chrome_service.(#7093)

* feat: enable parent nav link id

* feat: modify left navigation

* feat: modify style

* feat: enable left bottom

* temp: merge

* feat: save

* feat: merge

* temp change

* temp change

* fix: overview page can not be load

* feat: remove useless change

* feat: add unit test

* feat: update snapshot

* fix: unit test error

* fix: new application

* feat: add unit test

* feat: update category based on latest design

* feat: update

* feat: update snapshot

* feat: do not emphasize see all link

* Changeset file for PR #7230 created/updated

* feat: update

* feat: update

---------



(cherry picked from commit b28aa98)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

yenienserrano mentioned this pull request

Compatibility with OpenSearch 2.16.0 wazuh/wazuh-dashboard#265

Closed

5 tasks

AMoo-Miki removed the failed backport label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ruanyl ruanyl approved these changes

BionIT BionIT approved these changes

ananzh Awaiting requested review from ananzh ananzh is a code owner

kavilla Awaiting requested review from kavilla kavilla is a code owner

AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

curq Awaiting requested review from curq curq is a code owner

bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

Labels

all-star-contributor backport 2.x navigation v2.16.0