Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace]Add instruction for force enable new navigation for workspace #7186

Merged

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented Jul 8, 2024

Description

Add a config in opensearch_dashbaords.yml file to force enable new nav/home and make the item in advanced setting read only. This is useful when workspace is enabled, that would help user have better UI experience for workspace.

uiSettings:
  overrides:
    "home:useNewHomePage": true

Issues Resolved

Screenshot

image

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.56%. Comparing base (901e39f) to head (4de8822).
Report is 347 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7186      +/-   ##
==========================================
- Coverage   67.56%   67.56%   -0.01%     
==========================================
  Files        3469     3469              
  Lines       68499    68499              
  Branches    11138    11138              
==========================================
- Hits        46280    46278       -2     
- Misses      19514    19515       +1     
- Partials     2705     2706       +1     
Flag Coverage Δ
Linux_1 33.15% <ø> (ø)
Linux_2 55.25% <ø> (ø)
Linux_3 45.30% <ø> (-0.02%) ⬇️
Linux_4 34.72% <ø> (ø)
Windows_1 33.17% <ø> (ø)
Windows_2 55.21% <ø> (ø)
Windows_3 45.32% <ø> (ø)
Windows_4 34.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hailong-am Hailong-am changed the title Add instruction for force enable new navigation for workspace [Workspace]Add instruction for force enable new navigation for workspace Jul 8, 2024
@SuZhou-Joe SuZhou-Joe merged commit 3a32191 into opensearch-project:main Jul 9, 2024
77 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 9, 2024
Signed-off-by: Hailong Cui <[email protected]>
(cherry picked from commit 3a32191)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Jul 19, 2024
…#7202)

(cherry picked from commit 3a32191)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x in-next seasoned-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.16.0 workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants