-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Multiple Datasource][Version Decoupling] Add data source version and installed plugins in MDS data source viewer returns #7172
Conversation
… installed plugins in MDS data source viewer returns Signed-off-by: Zilong Xia <[email protected]>
❌ Entry Too LongEntry is 106 characters long, which is 6 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
❌ Entry Too LongEntry is 106 characters long, which is 6 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
2 similar comments
❌ Entry Too LongEntry is 106 characters long, which is 6 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
❌ Entry Too LongEntry is 106 characters long, which is 6 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
❌ Entry Too LongEntry is 106 characters long, which is 6 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
2 similar comments
❌ Entry Too LongEntry is 106 characters long, which is 6 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
❌ Entry Too LongEntry is 106 characters long, which is 6 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7172 +/- ##
=======================================
Coverage 67.57% 67.58%
=======================================
Files 3469 3469
Lines 68497 68499 +2
Branches 11138 11138
=======================================
+ Hits 46288 46292 +4
+ Misses 19503 19502 -1
+ Partials 2706 2705 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This is cool. Thank you! I haven't looked how this is set. Like is this set just one time when the datasource is added or is it anytime the datasource is selected? Also do we plan on utilizing the capabilities service, for example link. For example, query assist there could be ML commons installed but doesn't have the chat feature. We could use the capabilities service for OSD plugins on the remote cluster to emit the capabilities that cluster has when it starts up and emit to the caller. |
It's onetime when the data source lists are loaded from saved objects. Basically this one to extend the fetch fields adding two more data source metadata in the returned list. For leveraging of the capabilities service based on my current knowledge not yet, might be a promising one though and I'll check it out, but more it would be each individual plugin's choice preference. |
… installed plugins in MDS data source viewer returns (#7172) * [Multiple Datasource][Version Decoupling] Add data source version and installed plugins in MDS data source viewer returns Signed-off-by: Zilong Xia <[email protected]> * Changeset file for PR #7172 created/updated --------- Signed-off-by: Zilong Xia <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 901e39f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
… installed plugins in MDS data source viewer returns (#7172) (#7184) * [Multiple Datasource][Version Decoupling] Add data source version and installed plugins in MDS data source viewer returns * Changeset file for PR #7172 created/updated --------- (cherry picked from commit 901e39f) Signed-off-by: Zilong Xia <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
dataSourceVersion
andinstalledPlugins
in all data source viewers.Issues Resolved
#7099
Screenshot
Changelog
Check List
yarn test:jest
yarn test:jest_integration