Update error message in timeline visualization when MDS disabled #7069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhongnan Su <[email protected]>
zhongnansu
added
ux / ui
zhongnansu
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
2 tasks
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
xinruiba
approved these changes
Jun 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7069 +/- ##
==========================================
- Coverage 67.45% 67.44% -0.01%
==========================================
Files 3445 3445
Lines 67884 67884
Branches 11037 11037
==========================================
- Hits 45788 45786 -2
- Misses 19429 19430 +1
- Partials 2667 2668 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
huyaboo
approved these changes
Jun 19, 2024
BionIT
approved these changes
Jun 20, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
* Update error message in timeline visualization when MDS disabled Signed-off-by: Zhongnan Su <[email protected]> * Changeset file for PR #7069 created/updated --------- Signed-off-by: Zhongnan Su <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 50f1066) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhongnansu
pushed a commit
that referenced
this pull request
Jun 20, 2024
…) (#7074) * Update error message in timeline visualization when MDS disabled * Changeset file for PR #7069 created/updated --------- (cherry picked from commit 50f1066) Signed-off-by: Zhongnan Su <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
mengweieric
pushed a commit
to mengweieric/OpenSearch-Dashboards
that referenced
this pull request
Jun 24, 2024
…nsearch-project#7069) * Update error message in timeline visualization when MDS disabled Signed-off-by: Zhongnan Su <[email protected]> * Changeset file for PR opensearch-project#7069 created/updated --------- Signed-off-by: Zhongnan Su <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based in UX requirement, update error message in timeline visualization when MDS disabled.
Issues Resolved
#7000
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration