[BUG][NewHomePage] Temp Solution to avoid crash for user with no write permission #7054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th no write permission Issue Resolve: opensearch-project#6320 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
requested review from
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
ananzh
added
backport 2.x
backport 2.15
bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7054 +/- ##
==========================================
+ Coverage 67.44% 67.46% +0.01%
==========================================
Files 3445 3445
Lines 67886 67884 -2
Branches 11037 11037
==========================================
+ Hits 45788 45798 +10
+ Misses 19431 19418 -13
- Partials 2667 2668 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ananzh
changed the title
| .save({}) | ||
| .then(() => error$.next(undefined)) | ||
| .catch((e) => error$.next(e)); | ||
| homepage.save({}); |
There was a problem hiding this comment.
is there anything that tracks fixing this permanently?
There was a problem hiding this comment.
I could open an issue. Currently we are using this tmp one for unblocking purpose.
There was a problem hiding this comment.
actually we could keep the issue open and revisit to see if there is better solution
There was a problem hiding this comment.
Hi Anan. Will this fix have some potential issue as it swallowed the error. Will it show information that not suppose to show to user?
There was a problem hiding this comment.
Maybe we could leave a comment here to describe why it's crashed(I'm curious ;)
AMoo-Miki
approved these changes
Jun 19, 2024
manasvinibs
approved these changes
Jun 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
…e permission (#7054) * [BUG][NewHomePage] Temp Solution to avoid crash for anonymous user with no write permission Issue Resolve: #6320 --------- Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 25009ba) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
…e permission (#7054) * [BUG][NewHomePage] Temp Solution to avoid crash for anonymous user with no write permission Issue Resolve: #6320 --------- Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 25009ba) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh
pushed a commit
that referenced
this pull request
Jun 19, 2024
…e permission (#7054) (#7063) * [BUG][NewHomePage] Temp Solution to avoid crash for anonymous user with no write permission Issue Resolve: #6320 --------- (cherry picked from commit 25009ba) Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ananzh
pushed a commit
that referenced
this pull request
Jun 19, 2024
…e permission (#7054) (#7064) * [BUG][NewHomePage] Temp Solution to avoid crash for anonymous user with no write permission Issue Resolve: #6320 --------- (cherry picked from commit 25009ba) Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
mengweieric
pushed a commit
to mengweieric/OpenSearch-Dashboards
that referenced
this pull request
Jun 24, 2024
…e permission (opensearch-project#7054) * [BUG][NewHomePage] Temp Solution to avoid crash for anonymous user with no write permission Issue Resolve: opensearch-project#6320 --------- Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow new home page shown for user with no write permission
2024-06-18_15-22-22.mp4
Compared it without the change
2024-06-18_15-25-00.mp4
Issues Resolved
#6320
Changelog
Check List
yarn test:jestyarn test:jest_integration