Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport to 2.x] Manual backport #6903 #6952

Merged

Conversation

yujin-emma
Copy link
Contributor

Description

Manual backport #6903

Issues Resolved

#6903

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.49%. Comparing base (453e579) to head (b10f8bb).

Files Patch % Lines
.../data_source_management/public/components/utils.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #6952   +/-   ##
=======================================
  Coverage   67.49%   67.49%           
=======================================
  Files        3443     3444    +1     
  Lines       67935    67939    +4     
  Branches    11042    11043    +1     
=======================================
+ Hits        45855    45858    +3     
- Misses      19414    19416    +2     
+ Partials     2666     2665    -1     
Flag Coverage Δ
Linux_1 33.08% <ø> (ø)
Linux_2 55.20% <ø> (ø)
Linux_3 45.25% <80.95%> (+<0.01%) ⬆️
Linux_4 34.96% <5.26%> (-0.02%) ⬇️
Windows_1 33.10% <ø> (ø)
Windows_2 55.15% <ø> (ø)
Windows_3 45.25% <80.95%> (-0.01%) ⬇️
Windows_4 34.96% <5.26%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhongnansu
Copy link
Member

zhongnansu commented Jun 6, 2024

@yujin-emma could you update the title do be more descriptive?
E.g. [Manual backport 2.x] "your change or commit message"

@yujin-emma yujin-emma changed the title [Backport] Manual backport #6903 [Manual Backport to 2.x] Manual backport #6903 Jun 6, 2024
@xinruiba xinruiba merged commit c0d0b7e into opensearch-project:2.x Jun 6, 2024
67 of 68 checks passed
@yujin-emma yujin-emma deleted the backport/backport-6903-to-2.x branch June 6, 2024 20:04
@zhongnansu zhongnansu added the multiple datasource multiple datasource project label Jun 10, 2024
@zhyuanqi zhyuanqi added the enhancement New feature or request label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request multiple datasource multiple datasource project Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants