[Backport 2.x] Update json5 dependency #6946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Update json5 Signed-off-by: Simeon Widdis <[email protected]> * Update changelog Signed-off-by: Simeon Widdis <[email protected]> * Revert "Update changelog" This reverts commit 526e0bb. Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]> Co-authored-by: Lu Yu <[email protected]> (cherry picked from commit 9674147) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
github-actions
bot
added
failed changeset
and removed
Skip-Changelog
BionIT
approved these changes
Jun 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6946 +/- ##
==========================================
- Coverage 67.50% 67.49% -0.01%
==========================================
Files 3443 3443
Lines 67935 67935
Branches 11042 11042
==========================================
- Hits 45861 45855 -6
- Misses 19409 19414 +5
- Partials 2665 2666 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
need to revert this due to breaking change |
ananzh
requested changes
Jun 6, 2024
There was a problem hiding this comment.
breaking change dividab/tsconfig-paths#173 but should be fine check this comment #6937 (comment)
ananzh
approved these changes
Jun 6, 2024
74 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 9674147 from #6937.