-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDS] Fix sample data to use datasources for TSVB visualizations #6940
Merged
BionIT
merged 2 commits into
opensearch-project:main
from
huyaboo:tsvb-install-sample-data
Jun 6, 2024
Merged
[MDS] Fix sample data to use datasources for TSVB visualizations #6940
BionIT
merged 2 commits into
opensearch-project:main
from
huyaboo:tsvb-install-sample-data
Jun 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huyaboo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
June 6, 2024 00:34
opensearch-changeset-bot bot
added a commit
to huyaboo/OpenSearch-Dashboards
that referenced
this pull request
Jun 6, 2024
huyaboo
force-pushed
the
tsvb-install-sample-data
branch
from
June 6, 2024 00:36
84d8337
to
863368f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6940 +/- ##
==========================================
- Coverage 67.43% 67.43% -0.01%
==========================================
Files 3443 3443
Lines 67806 67811 +5
Branches 11031 11032 +1
==========================================
+ Hits 45727 45730 +3
- Misses 19413 19414 +1
- Partials 2666 2667 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhongnansu
approved these changes
Jun 6, 2024
BionIT
approved these changes
Jun 6, 2024
45 tasks
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
* Fix sample data to use datasources for TSVB visualizations Signed-off-by: Huy Nguyen <[email protected]> * Changeset file for PR #6940 created/updated --------- Signed-off-by: Huy Nguyen <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 61e29b5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jun 6, 2024
…) (#6943) * Fix sample data to use datasources for TSVB visualizations * Changeset file for PR #6940 created/updated --------- (cherry picked from commit 61e29b5) Signed-off-by: Huy Nguyen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds TSVB support for "Add Sample Data" when MDS is enabled
Issues Resolved
Closes #6936
Screenshot
Navigating when MDS is disabled
Screen.Recording.2024-06-05.at.5.25.01.PM.mov
Navigating when MDS is enabled
Screen.Recording.2024-06-05.at.5.20.01.PM.mov
Testing the changes
When MDS is disabled
DataSourceSelector
component should not be visibleWhen MDS is enabled
DataSourceSelector
component should be visibleDataSourceSelector
should have the correct datasource option selected on initial renderChangelog
Check List
yarn test:jest
yarn test:jest_integration