Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FieldEditor test snapshots #691

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Update FieldEditor test snapshots #691

merged 1 commit into from
Aug 4, 2021

Conversation

tmarkley
Copy link
Contributor

@tmarkley tmarkley commented Aug 3, 2021

Description

Previous PR #674 did not include updated snapshots.

Signed-off-by: Tommy Markley [email protected]

Issues Resolved

Related to #673

Testing

$ yarn test:jest
...
Test Suites: 1 skipped, 1434 passed, 1434 of 1435 total
Tests:       24 skipped, 9 todo, 10637 passed, 10670 total
Snapshots:   2410 passed, 2410 total
Time:        47.32 s
Ran all test suites.
Done in 49.23s.

$ yarn test:jest_integration
...
Test Suites: 50 passed, 50 total
Tests:       4 skipped, 433 passed, 437 total
Snapshots:   73 passed, 73 total
Time:        307.323 s
Ran all test suites.
         │ info [opensearch] cleanup complete
Done in 309.62s.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

Update FieldEditor test snapshots
510e569 
Previous PR opensearch-project#674 did not include updated snapshots.

Related to opensearch-project#673

Signed-off-by: Tommy Markley <[email protected]>
@tmarkley tmarkley requested review from kavilla, boktorbb and ananzh August 3, 2021 16:57
@tmarkley tmarkley self-assigned this Aug 3, 2021
@tmarkley tmarkley mentioned this pull request Aug 3, 2021
Merged
1 task
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 510e569

boktorbb
boktorbb approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmarkley tmarkley merged commit f973822 into opensearch-project:main Aug 4, 2021
@tmarkley tmarkley deleted the issue-673 branch August 4, 2021 19:47
tmarkley pushed a commit to tmarkley/OpenSearch-Dashboards that referenced this pull request Aug 5, 2021
Update FieldEditor test snapshots (opensearch-project#691)
a3684aa 
Previous PR opensearch-project#674 did not include updated snapshots.

Related to opensearch-project#673

Signed-off-by: Tommy Markley <[email protected]>
@tmarkley tmarkley mentioned this pull request Aug 5, 2021
Merged
1 task
tmarkley pushed a commit that referenced this pull request Aug 6, 2021
Update FieldEditor test snapshots (#691) (#703)
3a28228 
Previous PR #674 did not include updated snapshots.

Related to #673

Signed-off-by: Tommy Markley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@boktorbb boktorbb boktorbb approved these changes

@kavilla kavilla kavilla approved these changes

Assignees

@tmarkley tmarkley

Labels
test:unit v1.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tmarkley @opensearch-ci-bot @kavilla @boktorbb @ananzh