Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workspace]Change workspace description field to textarea #6907

Merged
merged 5 commits into from
Jun 7, 2024
Merged

[Workspace]Change workspace description field to textarea #6907

merged 5 commits into from
Jun 7, 2024

Conversation

wanglam
Copy link
Contributor

@wanglam wanglam commented Jun 4, 2024 •
edited
Loading

Description

  1. Change workspace description to textarea component
  2. Remove workspace description field validation logic

Issues Resolved

Screenshot

image

Testing the changes

  • Clone branch code and run yarn osd bootstrap
  • Add below configuration to config/opensearch_dashboards.yml
opensearchDashboards.dashboardAdmin.users: ['admin']
workspace.enabled: true
  • Login with admin user and visit workspace create page
  • Workspace description will become textarea and symbol like "." "_" can be input
  • Click Create workspace then workspace can be created.
  • Will navigate to workspace overview page, new added description will be dispalyed.

Changelog

  • feat: [Workspace] Change description field to textarea

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-changeset-bot bot added a commit to wanglam/OpenSearch-Dashboards that referenced this pull request Jun 4, 2024
@opensearch-changeset-bot
Changeset file for PR opensearch-project#6907 created/updated
706b04e
@codecov Codecov
Copy link

codecov bot commented Jun 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.38%. Comparing base (efab1a8) to head (969610e).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6907      +/-   ##
==========================================
- Coverage   67.43%   67.38%   -0.06%     
==========================================
  Files        3443     3443              
  Lines       67815    67813       -2     
  Branches    11033    11032       -1     
==========================================
- Hits        45734    45697      -37     
- Misses      19414    19491      +77     
+ Partials     2667     2625      -42
Flag Coverage Δ
Linux_1 33.09% <100.00%> (-0.01%) ⬇️
Linux_2 ?
Linux_3 45.20% <ø> (-0.02%) ⬇️
Linux_4 34.89% <ø> (ø)
Windows_1 33.11% <100.00%> (-0.01%) ⬇️
Windows_2 55.01% <ø> (-0.02%) ⬇️
Windows_3 45.22% <ø> (ø)
Windows_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanglam wanglam force-pushed the feat-change-workspace-description-to-textarea branch from 706b04e to 84249f9 Compare June 5, 2024 01:51
@wanglam wanglam changed the title Change workspace description field to textarea [Workspace]Change workspace description field to textarea Jun 5, 2024
@BionIT
Copy link
Collaborator

BionIT commented Jun 5, 2024

Hi @wanglam, is this PR for 2.15 or 2.16?

@wanglam
Copy link
Contributor Author

wanglam commented Jun 5, 2024

Hi @wanglam, is this PR for 2.15 or 2.16?

Hi @BionIT , this PR is for 2.15. Feel free to help me add a label. Thank you.

@wanglam wanglam marked this pull request as ready for review June 5, 2024 02:57
@BionIT BionIT added the v2.15.0 label Jun 5, 2024
SuZhou-Joe
SuZhou-Joe previously approved these changes Jun 6, 2024
View reviewed changes
ruanyl
ruanyl previously approved these changes Jun 6, 2024
View reviewed changes
@wanglam wanglam dismissed stale reviews from SuZhou-Joe and ruanyl via 969610e June 6, 2024 13:38
@lauralexis
Copy link

lauralexis commented Jun 6, 2024 •
edited
Loading

@wanglam UX looks good to me

@wanglam
Copy link
Contributor Author

wanglam commented Jun 6, 2024

@ruanyl @SuZhou-Joe I've tweaked the UI slightly. Now the new UI can be signoff. Could you help me take a look?

@ruanyl ruanyl merged commit fe443e9 into opensearch-project:main Jun 7, 2024
67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 7, 2024
@github-actions @opensearch-changeset-bot @BionIT
[Workspace]Change workspace description field to textarea (#6907)
ac84cf2 
* Change workspace description field to textarea

Signed-off-by: Lin Wang <[email protected]>

* Changeset file for PR #6907 created/updated

* Update description UI

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Lu Yu <[email protected]>
(cherry picked from commit fe443e9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 7, 2024
Merged
ruanyl pushed a commit that referenced this pull request Jun 7, 2024
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @BionIT
[Workspace]Change workspace description field to textarea (#6907) (#6960
642e4d3 
)

* Change workspace description field to textarea



* Changeset file for PR #6907 created/updated

* Update description UI



---------




(cherry picked from commit fe443e9)

Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Lu Yu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanyl ruanyl ruanyl approved these changes

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

Assignees

@ruanyl ruanyl

@SuZhou-Joe SuZhou-Joe

Labels
backport 2.x v2.15.0 valued-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wanglam @BionIT @lauralexis @ruanyl @SuZhou-Joe