Add OpenAPI specification for bulk_get saved object APIs #6860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>
zhyuanqi
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba and
mengweieric
as code owners
zhyuanqi
added
backport 1.3
v2.15.0
docs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6860 +/- ##
==========================================
- Coverage 67.39% 67.38% -0.01%
==========================================
Files 3443 3443
Lines 67797 67797
Branches 11033 11033
==========================================
- Hits 45690 45688 -2
- Misses 19439 19440 +1
- Partials 2668 2669 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhongnansu
previously approved these changes
May 30, 2024
BionIT
reviewed
May 30, 2024
| summary: Bulk get saved objects | ||
| requestBody: | ||
| required: true | ||
| description: Array of saved objects to update |
There was a problem hiding this comment.
To update or to retrieve? The array is search criteria, right?
There was a problem hiding this comment.
THanks for pointing this out. Will make the change
BionIT
reviewed
May 30, 2024
Co-authored-by: Lu Yu <[email protected]> Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>
BionIT
approved these changes
May 30, 2024
zhongnansu
approved these changes
May 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 30, 2024
* Add OpenAPI specification for bulk_get saved object APIs Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> * Changeset file for PR #6860 created/updated * Apply suggestions from code review Co-authored-by: Lu Yu <[email protected]> Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> --------- Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lu Yu <[email protected]> (cherry picked from commit 6b2db4d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhyuanqi
pushed a commit
that referenced
this pull request
May 30, 2024
* Add OpenAPI specification for bulk_get saved object APIs * Changeset file for PR #6860 created/updated * Apply suggestions from code review --------- (cherry picked from commit 6b2db4d) Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lu Yu <[email protected]>
45 tasks
LDrago27
pushed a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Jun 3, 2024
…project#6860) * Add OpenAPI specification for bulk_get saved object APIs Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> * Changeset file for PR opensearch-project#6860 created/updated * Apply suggestions from code review Co-authored-by: Lu Yu <[email protected]> Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> --------- Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lu Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add OpenAPI specification for bulk_get saved object APIs
Issues Resolved
#6719
Screenshot
Changelog
Check List
yarn test:jestyarn test:jest_integration