Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Getting Started section to the Developer Guide #685

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

tmarkley
Copy link
Contributor

@tmarkley tmarkley commented Jul 29, 2021

Description

  • Add development environment setup link to Welcome section of the README.
  • Remove broken Admin Responsibilities link from the README.

Signed-off-by: Tommy Markley [email protected]

Issues Resolved

Resolves #666

Check List

  • Commits are signed per the DCO using --signoff

@tmarkley tmarkley added docs Improvements or additions to documentation v1.1.0 labels Jul 29, 2021
@tmarkley tmarkley requested review from kavilla, boktorbb and ananzh July 29, 2021 17:52
@tmarkley tmarkley self-assigned this Jul 29, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 1f38879

DEVELOPER_GUIDE.md Outdated Show resolved Hide resolved
kavilla
kavilla previously approved these changes Jul 29, 2021
@galangel
Copy link
Contributor

galangel commented Aug 1, 2021

I'm using volta for version management, am I the only one?

* Add development environment setup link to Welcome section of the README.
* Remove broken Admin Responsibilities link from the README.

Resolves opensearch-project#666

Signed-off-by: Tommy Markley <[email protected]>
@tmarkley tmarkley changed the title Add Getting Started section to Developer Guide Add Getting Started section to the Developer Guide Aug 3, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 68b7916

@tmarkley
Copy link
Contributor Author

tmarkley commented Aug 3, 2021

@galangel We haven't adopted Volta, but it looks useful. Do you have a suggestion for incorporating it into the Getting Started instructions?

@tmarkley tmarkley requested a review from kavilla August 3, 2021 04:07
@tmarkley tmarkley merged commit 07ea9f4 into opensearch-project:main Aug 3, 2021
@tmarkley tmarkley deleted the issue-666 branch August 3, 2021 17:18
@tmarkley tmarkley restored the issue-666 branch August 3, 2021 17:19
tmarkley pushed a commit to tmarkley/OpenSearch-Dashboards that referenced this pull request Aug 3, 2021
…t#685)

* Add development environment setup link to Welcome section of the README.
* Remove broken Admin Responsibilities link from the README.

Resolves opensearch-project#666

Signed-off-by: Tommy Markley <[email protected]>
tmarkley pushed a commit that referenced this pull request Aug 3, 2021
* Add development environment setup link to Welcome section of the README.
* Remove broken Admin Responsibilities link from the README.

Resolves #666

Signed-off-by: Tommy Markley <[email protected]>
@tmarkley tmarkley deleted the issue-666 branch August 3, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation v1.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Developer guide does not have instructions on how to build Dashboards locally
5 participants