fix for quickrange to use datemath to parse datetime strings #6782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Sebastian <[email protected]>
paulstn
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 6782.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6782 +/- ##
==========================================
- Coverage 67.56% 67.35% -0.21%
==========================================
Files 3428 3443 +15
Lines 67343 67795 +452
Branches 10996 11032 +36
==========================================
+ Hits 45498 45666 +168
- Misses 19176 19434 +258
- Partials 2669 2695 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kavilla
reviewed
May 14, 2024
manasvinibs
reviewed
May 20, 2024
opensearch-changeset-bot
bot
requested review from
zhyuanqi and
mengweieric
as code owners
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
paulstn
commented
May 23, 2024
|
|
||
| describe('Data Frame Utils', () => { | ||
| describe('formatTimePickerDate function', () => { | ||
| Date.now = jest.fn(() => new Date('2024-05-04T12:30:00.000Z')); |
There was a problem hiding this comment.
@kavilla is this fine for mocking the time or is there another preferred option?
Signed-off-by: Paul Sebastian <[email protected]>
kavilla
reviewed
May 24, 2024
kavilla
reviewed
May 24, 2024
Signed-off-by: Paul Sebastian <[email protected]>
kavilla
approved these changes
May 24, 2024
manasvinibs
approved these changes
May 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 24, 2024
provides a formatting util function meant to convert quick range time (such as 'now-15m') to datetimes that can be understood. Signed-off-by: Paul Sebastian <[email protected]> --------- Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 347639f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 30, 2024
provides a formatting util function meant to convert quick range time (such as 'now-15m') to datetimes that can be understood. Signed-off-by: Paul Sebastian <[email protected]> --------- Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 347639f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla
pushed a commit
that referenced
this pull request
May 30, 2024
…6868) provides a formatting util function meant to convert quick range time (such as 'now-15m') to datetimes that can be understood. --------- (cherry picked from commit 347639f) Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
LDrago27
pushed a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Jun 3, 2024
…rch-project#6782) provides a formatting util function meant to convert quick range time (such as 'now-15m') to datetimes that can be understood. Signed-off-by: Paul Sebastian <[email protected]> --------- Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
kavilla
pushed a commit
that referenced
this pull request
Jun 4, 2024
…6834) provides a formatting util function meant to convert quick range time (such as 'now-15m') to datetimes that can be understood. --------- (cherry picked from commit 347639f) Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
provides a formatting util function meant to convert quick range time (such as 'now-15m') to datetimes that can be understood.
related to: kavilla/qlDashboards#4
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration