Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CODE_OF_CONDUCT markdown file to fix broken link in README #677

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Add CODE_OF_CONDUCT markdown file to fix broken link in README #677

merged 1 commit into from
Jul 28, 2021

Conversation

sagar-rout
Copy link
Contributor

@sagar-rout sagar-rout commented Jul 27, 2021 •
edited by tmarkley
Loading

Signed-off-by: Sagar Rout [email protected]

Description

Fixes broken Code of Conduct markdown link in README.md

Issues Resolved

Resolves #676

Check List

  • Commits are signed per the DCO using --signoff

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 8392155

tmarkley
tmarkley previously approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@tmarkley tmarkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change Sagar!

kavilla
kavilla previously approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@kavilla
Copy link
Member

kavilla commented Jul 27, 2021

NIT: The commit message doesn't have a detailed description but I think the message is descriptive enough. Perhaps we can take 676 out of the message and link the issue in the git description so it's a little bit cleaner?

@sagar-rout sagar-rout dismissed stale reviews from kavilla and tmarkley via fbb0bc3 July 28, 2021 02:10
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed fbb0bc3

@sagar-rout
[BUG] fix CODE_OF_CONDUCT link in README.md (opensearch-project#676)
84d6482 
Add CODE_OF_CONDUCT file, Copy CODE_OF_CONDUCT file from https://github.com/opensearch-project/OpenSearch repository.

Signed-off-by: Sagar Rout <[email protected]>
@sagar-rout
Copy link
Contributor Author

NIT: The commit message doesn't have a detailed description but I think the message is descriptive enough. Perhaps we can take 676 out of the message and link the issue in the git description so it's a little bit cleaner?

yes, you are right. I fixed the git commit message. Could you please have a look when you have sometime ? Thanks.

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 84d6482

@kavilla kavilla self-requested a review July 28, 2021 18:12
tmarkley
tmarkley approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@tmarkley tmarkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sagar-rout sagar-rout closed this Jul 28, 2021
@sagar-rout sagar-rout reopened this Jul 28, 2021
@sagar-rout
Copy link
Contributor Author

Hi, I don’t think I can merge the changes into main branch. Can someone please merge this PR who has write access ? Thanks

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 84d6482

@tmarkley tmarkley changed the title 676 | add CODE_OF_CONDUCT markdown file to fix broken link in README Add CODE_OF_CONDUCT markdown file to fix broken link in README Jul 28, 2021
@tmarkley tmarkley added docs Improvements or additions to documentation v1.1.0 labels Jul 28, 2021
@kavilla kavilla merged commit e291185 into opensearch-project:main Jul 28, 2021
@kavilla
Copy link
Member

kavilla commented Jul 28, 2021

Would you be able to backport to this into the 1.x branch.

@sagar-rout sagar-rout deleted the bugfix/676 branch July 29, 2021 02:55
tmarkley pushed a commit to tmarkley/OpenSearch-Dashboards that referenced this pull request Aug 3, 2021
@sagar-rout
[BUG] fix CODE_OF_CONDUCT link in README.md (opensearch-project#676) (o…
28a2d8d 
…pensearch-project#677)

Add CODE_OF_CONDUCT file, Copy CODE_OF_CONDUCT file from https://github.com/opensearch-project/OpenSearch repository.

Signed-off-by: Sagar Rout <[email protected]>
@tmarkley tmarkley mentioned this pull request Aug 3, 2021
Merged
1 task
tmarkley pushed a commit that referenced this pull request Aug 4, 2021
[BUG] fix CODE_OF_CONDUCT link in README.md (#677) (#696)
42b2272 
Add CODE_OF_CONDUCT file, Copy CODE_OF_CONDUCT file from https://github.com/opensearch-project/OpenSearch repository.

Resolves #676

Signed-off-by: Sagar Rout <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@tmarkley tmarkley tmarkley approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@boktorbb boktorbb Awaiting requested review from boktorbb

Assignees
No one assigned
Labels
docs Improvements or additions to documentation v1.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] README Section has broken link in Code of Conduct "Amazon Open Source Code of Conduct"
4 participants
@sagar-rout @opensearch-ci-bot @kavilla @tmarkley