Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Manual Backport 2.x] Feat (core): Make theme settings user-specific and user-configurable (#5652) (#6681)" #6736

Merged
merged 1 commit into from
May 7, 2024

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented May 7, 2024

This reverts commit 815d2bd.

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 62.26415% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 67.76%. Comparing base (8382e5c) to head (a9948e2).

Files Patch % Lines
src/core/server/rendering/rendering_service.tsx 29.41% 6 Missing and 6 partials ⚠️
src/legacy/ui/ui_render/ui_render_mixin.js 0.00% 6 Missing ⚠️
src/core/server/rendering/views/theme.ts 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             2.14    #6736      +/-   ##
==========================================
+ Coverage   67.73%   67.76%   +0.03%     
==========================================
  Files        3414     3413       -1     
  Lines       66941    66878      -63     
  Branches    10874    10867       -7     
==========================================
- Hits        45341    45321      -20     
+ Misses      18960    18895      -65     
- Partials     2640     2662      +22     
Flag Coverage Δ
Linux_1 33.18% <12.50%> (+<0.01%) ⬆️
Linux_2 ?
Linux_4 ?
Windows_1 33.20% <12.50%> (+<0.01%) ⬆️
Windows_2 55.70% <54.16%> (+0.07%) ⬆️
Windows_3 45.25% <22.22%> (+0.01%) ⬆️
Windows_4 35.02% <17.02%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kavilla
Copy link
Member Author

kavilla commented May 7, 2024

failures unrelated

@kavilla kavilla merged commit 23986b6 into opensearch-project:2.14 May 7, 2024
80 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants