Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport 2.x] feat: add config for topRightNavigation #6727

Merged
merged 1 commit into from
May 7, 2024

Conversation

raintygao
Copy link
Contributor

Backport PR

#6712

Description

  1. Add opensearchDashboards.futureNavigation config and control dev tool top right nav button.
  2. Mark rightNavigationButton component as experimental.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.74%. Comparing base (db8a8e5) to head (0de4717).

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #6727   +/-   ##
=======================================
  Coverage   67.73%   67.74%           
=======================================
  Files        3414     3414           
  Lines       66922    66922           
  Branches    10870    10870           
=======================================
+ Hits        45331    45333    +2     
+ Misses      18953    18952    -1     
+ Partials     2638     2637    -1     
Flag Coverage Δ
Linux_1 33.19% <ø> (ø)
Linux_2 55.66% <ø> (ø)
Linux_3 45.27% <ø> (+<0.01%) ⬆️
Linux_4 35.00% <ø> (ø)
Windows_1 33.21% <ø> (ø)
Windows_2 55.63% <ø> (ø)
Windows_3 45.27% <ø> (ø)
Windows_4 35.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashwin-pc ashwin-pc merged commit 3526ac6 into opensearch-project:2.x May 7, 2024
65 of 83 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 7, 2024
Signed-off-by: tygao <[email protected]>
(cherry picked from commit 3526ac6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla pushed a commit that referenced this pull request May 7, 2024
…#6728)

(cherry picked from commit 3526ac6)

Signed-off-by: tygao <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants