[1.x][Test] Fix console error in search_service.test.ts #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run unit test suite search_service.test.ts has a console error: ``` UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'aggs' of undefined ``` This is caused by a missing promise result check in the setup fun in search_service.ts. If the promise result is empty (or null/undefined), then any properties of the empty result is undefined. In our case, `aggs` in `if (value.search.aggs.shardDelay.enabled)` is undefined. In this PR, we fixed this issue by adding a value check in setup fun. Issues resolved: opensearch-project#594 Backport PR: opensearch-project#595 Signed-off-by: Anan Zhuang <[email protected]>
|
✅ DCO Check Passed 83ba64a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Run unit test suite search_service.test.ts has a console error:
This is caused by a missing promise result check in the setup fun
in search_service.ts. If the promise result is empty (or null/undefined),
then any properties of the empty result is undefined. In our case,
aggsinif (value.search.aggs.shardDelay.enabled)is undefined.In this PR, we fixed this issue by adding a value check in setup fun.
Issues resolved:
#594
Backport PR:
#595
Signed-off-by: Anan Zhuang [email protected]
Check List