Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] fix: update DSM id in workspace #6650

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

raintygao
Copy link
Contributor

Description

Workspace depends on DSM id to filter, update DSM id in workspace accordingly DSM change.

Screenshot

image
image

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.79%. Comparing base (b29d90e) to head (b11539f).

Files Patch % Lines
src/plugins/workspace/public/plugin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6650   +/-   ##
=======================================
  Coverage   67.79%   67.79%           
=======================================
  Files        3413     3413           
  Lines       66755    66755           
  Branches    10861    10861           
=======================================
+ Hits        45254    45256    +2     
+ Misses      18857    18856    -1     
+ Partials     2644     2643    -1     
Flag Coverage Δ
Linux_1 33.18% <0.00%> (ø)
Linux_2 55.63% <ø> (ø)
Linux_3 45.26% <ø> (+0.01%) ⬆️
Linux_4 34.91% <ø> (ø)
Windows_1 33.21% <0.00%> (ø)
Windows_2 55.59% <ø> (ø)
Windows_3 45.26% <ø> (ø)
Windows_4 34.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 857f8cb into opensearch-project:main Apr 26, 2024
68 of 69 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 26, 2024
Signed-off-by: tygao <[email protected]>
(cherry picked from commit 857f8cb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Apr 27, 2024
(cherry picked from commit 857f8cb)

Signed-off-by: tygao <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDrago27 pushed a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.14.0 valued-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants