[Backport 2.x] [Workspace] Add workspace overview page #6641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* workspace overview page Signed-off-by: Hailong Cui <[email protected]> address review comments Signed-off-by: Hailong Cui <[email protected]> address ux review comments Signed-off-by: Hailong Cui <[email protected]> Add workspace overview to breadCrumb Signed-off-by: Hailong Cui <[email protected]> getting start modal & settings tab Signed-off-by: Hailong Cui <[email protected]> home breadcrumb Signed-off-by: Hailong Cui <[email protected]> fix rebase issue Signed-off-by: Hailong Cui <[email protected]> tmp enable management Signed-off-by: Hailong Cui <[email protected]> add workspace overview collapsed into localStorage Signed-off-by: Hailong Cui <[email protected]> getting start modal Signed-off-by: Hailong Cui <[email protected]> page layout Signed-off-by: Hailong Cui <[email protected]> Add test cases Signed-off-by: Hailong Cui <[email protected]> fix breadcrumb Signed-off-by: Hailong Cui <[email protected]> * fix merge issue Signed-off-by: Hailong Cui <[email protected]> * fix wrong dataSourceManagement id Signed-off-by: Hailong Cui <[email protected]> * Changeset file for PR #6584 created/updated * update page layout Signed-off-by: Hailong Cui <[email protected]> * overview tab layout update Signed-off-by: Hailong Cui <[email protected]> * fix workspace overview page breadcrumb Signed-off-by: Hailong Cui <[email protected]> * collapsed setting to be workspace level Signed-off-by: Hailong Cui <[email protected]> * fix workspace_overview_modal unit test Signed-off-by: Hailong Cui <[email protected]> * Update src/plugins/workspace/public/components/workspace_overview/getting_start_card.tsx Co-authored-by: SuZhou-Joe <[email protected]> Signed-off-by: Hailong Cui <[email protected]> * Update src/plugins/workspace/public/components/workspace_overview/workspace_overview_settings.tsx Co-authored-by: SuZhou-Joe <[email protected]> Signed-off-by: Hailong Cui <[email protected]> * Update src/plugins/workspace/public/components/workspace_overview/getting_start_modal.tsx Co-authored-by: SuZhou-Joe <[email protected]> Signed-off-by: Hailong Cui <[email protected]> * Update src/plugins/workspace/public/components/workspace_overview/getting_start_modal.tsx Co-authored-by: SuZhou-Joe <[email protected]> Signed-off-by: Hailong Cui <[email protected]> * Update src/plugins/workspace/public/components/workspace_overview/getting_start_modal.tsx Co-authored-by: SuZhou-Joe <[email protected]> Signed-off-by: Hailong Cui <[email protected]> * Update src/plugins/workspace/public/components/workspace_overview/getting_start_modal.tsx Co-authored-by: SuZhou-Joe <[email protected]> Signed-off-by: Hailong Cui <[email protected]> * address review comments Signed-off-by: Hailong Cui <[email protected]> * address review comments Signed-off-by: Hailong Cui <[email protected]> * fix setBreadcrumbs issue Signed-off-by: Hailong Cui <[email protected]> * wording change of breadcrumbs Signed-off-by: Hailong Cui <[email protected]> * udpate breadcrumb subscription to be a better name Signed-off-by: Hailong Cui <[email protected]> * Add unit test Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <[email protected]> (cherry picked from commit 9c884b0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
kavilla
reviewed
Apr 26, 2024
| // below categories are for workspace | ||
| getStarted: { | ||
| id: 'getStarted', | ||
| label: i18n.translate('core.ui.getStarted.label', { |
There was a problem hiding this comment.
I think the i18n might complain about the namespaces as it will expect workspace. Can we verify it @SuZhou-Joe with:
node ./scripts/i18n_extract.js --output-dir ./translations
There was a problem hiding this comment.
There will be errors but ignore the unrelated ones.
There was a problem hiding this comment.
@kavilla Yes, that will be error to complain it need to be under workspace namespace.
Error: Expected "core.ui.getStarted.label" id to have "workspace" namespace. See .i18nrc.json for the list of supported namespaces.
There was a problem hiding this comment.
create a follow up issue #6647
kavilla
reviewed
Apr 26, 2024
| <EuiModal onClose={onCloseModal} maxWidth={false} className="gettingStartModel"> | ||
| <EuiModalHeader> | ||
| <EuiModalHeaderTitle> | ||
| <h2>Define your path forward</h2> |
|
@kavilla Thanks for call it out, and @Hailong-am has raised a following issue to track that. |
SuZhou-Joe
approved these changes
Apr 26, 2024
ruanyl
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 9c884b0 from #6584.