[Multiple Datasource] Fix style for mobile view of a few data source components #6617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lu Yu <[email protected]>
BionIT
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl and
xinruiba
as code owners
github-actions
bot
added
the
Skip-Changelog
ZilongX
approved these changes
Apr 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6617 +/- ##
===========================================
+ Coverage 32.93% 67.42% +34.49%
===========================================
Files 2260 2650 +390
Lines 45769 50557 +4788
Branches 7200 9158 +1958
===========================================
+ Hits 15075 34090 +19015
+ Misses 29984 14223 -15761
- Partials 710 2244 +1534
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Apr 23, 2024
xinruiba
approved these changes
Apr 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
Signed-off-by: Lu Yu <[email protected]> (cherry picked from commit f80f059) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
BionIT
pushed a commit
that referenced
this pull request
Apr 23, 2024
(cherry picked from commit f80f059) Signed-off-by: Lu Yu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDrago27
pushed a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Jun 3, 2024
Signed-off-by: Lu Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fix the style of data source component for mobile view
Issues Resolved
Screenshot
Data source selectable in desktop
Data source selectable in mobile view
Data source view in desktop
Data source view in mobile
Data source list all in desktop
Data source list all in mobile
Data source list active in desktop
Data source list active in mobile
Testing the changes
Tested the change with screenshots above
Changelog
Check List
yarn test:jestyarn test:jest_integration