Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multiple Datasource] Add empty icon and fix empty state handling #6597

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

BionIT
Copy link
Collaborator

@BionIT BionIT commented Apr 22, 2024

Description

This change adds empty database icon to handle when there is no clusters to show, and I also changed the toast message and popover based on requirements.

Issues Resolved

Fixes #6565

Screenshot

emptystate.mp4

Testing the changes

The following steps were performed in the recording:

  1. go to multi select example, and see toasts about empty state, click on icon will show popover, the link in the popover goes to data source management page
  2. go to single select example, and see toasts about empty state, click on icon will show popover, the link in the popover goes to data source management page
  3. go to single readonly example, and see toasts about empty state, click on icon will show popover, the link in the popover goes to data source management page
  4. go to aggregated list all example, and see toasts about empty state, click on icon will show popover, the link in the popover goes to data source management page

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 51.85185% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 67.71%. Comparing base (d2d410b) to head (1957f2b).
Report is 23 commits behind head on main.

Files Patch % Lines
...ce_aggregated_view/data_source_aggregated_view.tsx 0.00% 4 Missing and 1 partial ⚠️
..._multi_selectable/data_source_multi_selectable.tsx 0.00% 4 Missing and 1 partial ⚠️
...lic/components/custom_database_icon/empty_icon.tsx 50.00% 1 Missing ⚠️
...ublic/components/no_data_source/no_data_source.tsx 75.00% 1 Missing ⚠️
...ponents/toast_button/manage_data_source_button.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6597       +/-   ##
===========================================
+ Coverage   32.93%   67.71%   +34.77%     
===========================================
  Files        2260     3403     +1143     
  Lines       45769    66588    +20819     
  Branches     7200    10820     +3620     
===========================================
+ Hits        15075    45091    +30016     
+ Misses      29984    18862    -11122     
- Partials      710     2635     +1925     
Flag Coverage Δ
Linux_1 33.06% <ø> (+0.13%) ⬆️
Linux_2 55.65% <ø> (?)
Linux_3 45.20% <51.85%> (?)
Linux_4 34.94% <11.11%> (?)
Windows_1 33.08% <ø> (?)
Windows_2 55.62% <ø> (?)
Windows_3 45.21% <51.85%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZilongX
Copy link
Collaborator

ZilongX commented Apr 23, 2024

picking up latest main and re-running all checks

@BionIT BionIT merged commit 543bbea into opensearch-project:main Apr 23, 2024
68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 23, 2024
)

* add empty icon and fix empty state handling

Signed-off-by: Lu Yu <[email protected]>

* add back missing import

Signed-off-by: Lu Yu <[email protected]>

---------

Signed-off-by: Lu Yu <[email protected]>
Co-authored-by: ZilongX <[email protected]>
(cherry picked from commit 543bbea)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
BionIT pushed a commit that referenced this pull request Apr 23, 2024
) (#6618)

* add empty icon and fix empty state handling



* add back missing import



---------



(cherry picked from commit 543bbea)

Signed-off-by: Lu Yu <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <[email protected]>
LDrago27 pushed a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jun 3, 2024
…ensearch-project#6597)

* add empty icon and fix empty state handling

Signed-off-by: Lu Yu <[email protected]>

* add back missing import

Signed-off-by: Lu Yu <[email protected]>

---------

Signed-off-by: Lu Yu <[email protected]>
Co-authored-by: ZilongX <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor backport 2.x multiple datasource multiple datasource project Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Multiple Datasource] Improvement on the empty state component for data source picker
3 participants