-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Multiple Datasource] Add empty icon and fix empty state handling #6597
Conversation
Signed-off-by: Lu Yu <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6597 +/- ##
===========================================
+ Coverage 32.93% 67.71% +34.77%
===========================================
Files 2260 3403 +1143
Lines 45769 66588 +20819
Branches 7200 10820 +3620
===========================================
+ Hits 15075 45091 +30016
+ Misses 29984 18862 -11122
- Partials 710 2635 +1925
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Lu Yu <[email protected]>
Signed-off-by: Lu Yu <[email protected]>
picking up latest main and re-running all checks |
) * add empty icon and fix empty state handling Signed-off-by: Lu Yu <[email protected]> * add back missing import Signed-off-by: Lu Yu <[email protected]> --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: ZilongX <[email protected]> (cherry picked from commit 543bbea) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) (#6618) * add empty icon and fix empty state handling * add back missing import --------- (cherry picked from commit 543bbea) Signed-off-by: Lu Yu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: ZilongX <[email protected]>
…ensearch-project#6597) * add empty icon and fix empty state handling Signed-off-by: Lu Yu <[email protected]> * add back missing import Signed-off-by: Lu Yu <[email protected]> --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: ZilongX <[email protected]>
Description
This change adds empty database icon to handle when there is no clusters to show, and I also changed the toast message and popover based on requirements.
Issues Resolved
Fixes #6565
Screenshot
emptystate.mp4
Testing the changes
The following steps were performed in the recording:
Changelog
Check List
yarn test:jest
yarn test:jest_integration